New issue
Advanced search Search tips

Issue 814481 link

Starred by 1 user
Status: Assigned
Owner:
msw@chromium.org
Cc:
msw@chromium.org
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 594887
issue 821551



Sign in to add a comment

Docked Magnifier uses ui::Reflector which doesn't seem to exist in mash

Project Member Reported by afakhry@chromium.org, Feb 21 2018 
I have to disable some ash unittests I'm trying to add in a new CL that implements the docked magnifier: https://chromium-review.googlesource.com/c/chromium/src/+/912760

aura::Env::GetInstance()->context_factory_private() returns null in mash unittests, which we use to create a reflector.

Comment 1 by msw@chromium.org, Feb 21 2018 

Perhaps related to Issue 601869? I was also planning on implementing display mirroring in mash/mus+viz without using reflectors at all (reflectors are used for mirroring in classic ash and mus without viz, see  issue 806318 ). I'm not sure if any of the display mirroring work would pertain to the magnifier, but rewriting the reflector in terms of cc surfaces might...

Comment 2 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService

Comment 3 by afakhry@chromium.org, Feb 27 2018

Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
Mike, please let's keep it on your plate then for now. Feel free to retriage as necessary.

Comment 4 by e...@chromium.org, Mar 9 2018

Cc: -e...@chromium.org
Un-cc-ing me from all bugs on my final day.

Comment 5 by jamescook@chromium.org, Mar 13 2018

Blocking: 821551

Comment 6 by jamescook@chromium.org, Mar 13 2018

Blocking: 594887

Comment 7 by msw@chromium.org, Aug 21

Labels: Proj-Mash-MultiProcess
This repros with --enable-features=Mash, but not --enable-features=SingleProcessMash
►

Sign in to add a comment