New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814475 link

Starred by 1 user
Status: Fixed
Owner:
kylec...@chromium.org
Closed: Apr 2018
Cc:
danakj@chromium.org
samans@chromium.org
█ fsam...@chromium.org
m...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 787097



Sign in to add a comment

viz: OnClientConnectionLost() does nothing

Project Member Reported by kylec...@chromium.org, Feb 21 2018 
With [Root]CompositorFrameSinkImpl the OnClientConnectionLost() code needs to be fixed. It notifies FrameSinkManagerImpl which in turn notifies HostFrameSinkManager over IPC. That message is unused now.

1. Can we destroy the [Root]CompositorFrameSinkImpl, including CompositorFrameSinkSupport, when the connection is lost? It's not going to be submitting anymore CompositorFrames. There is a DCHECK(capture_clients_.empty()) in the CompositorFrameSinkSupport destructor which needs some special attention.
2. Do we need an IPC back to HostFrameSinkManager. HostFrameSinkManager keeps track of if a client |has_created_compositor_frame_sink| and that could be updated. Also we could forward a message onto HostFrameSinkClient potentially to let it know something went wrong (maybe including surface invariant violation information).

Comment 1 by kylec...@chromium.org, Feb 22 2018 

1. The DCHECK doesn't seem to be an issue. FrameSinkManagerImpl::UnregisterCompositorFrameSinkSupport() handles removing everything from |capture_clients_| already.
2. I don't think HostFrameSinkManager needs to know if the client closed it's connection. There would be a race on ClientLayerTreeFrameSink recreation that isn't worth solving. It's only the HostFrameSinkClient that might want to know, but so far there hasn't been any need for that, so I think removing the IPC from mojom::FrameSinkManagerClient is the way to go.

Comment 2 by kylec...@chromium.org, Feb 22 2018 

This is pretty simple to fix, but it should have a test and we don't have any FrameSinkManagerImpl tests running in the VizDisplayCompositor mode (eg. has a DisplayProvider). I'm going to add a TestDisplayProvider to do this but that will require moving some things from cc/test to components/viz/test. Namely cc::TestSharedBitmapManager and cc::FakeOutputSurface should move to components/viz/test.

Comment 3 by danakj@chromium.org, Feb 22 2018 

That SG those are both subclasses of viz types.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc4845431987898f4ac57cb48650bde30e11a83

commit efc4845431987898f4ac57cb48650bde30e11a83
Author: kylechar <kylechar@chromium.org>
Date: Fri Feb 23 17:11:00 2018

Move TestSharedBitmapManager.

The SharedBitmapManager interface is part of viz. Move the test
implementation into components/viz/test to cleanup dependencies.

Bug:  814475 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I5b4f0129f8cf8c4e0f5f01e4e742a1bc89d314a5
Reviewed-on: https://chromium-review.googlesource.com/932843
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538808}
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/BUILD.gn
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/input/scroll_state_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/resources/layer_tree_resource_provider_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/test/layer_tree_test.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/test/pixel_test.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/test/pixel_test.h
[delete] https://crrev.com/f6b3696f3d96885f7b4dfcb62a5c9a44643de4a2/cc/test/test_shared_bitmap_manager.h
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/tiles/picture_layer_tiling_set_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/test/BUILD.gn
[rename] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/test/test_shared_bitmap_manager.cc
[add] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/components/viz/test/test_shared_bitmap_manager.h
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/content/public/test/DEPS
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/content/public/test/mock_render_thread.h
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/content/test/DEPS
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/efc4845431987898f4ac57cb48650bde30e11a83/ui/compositor/test/in_process_context_factory.h
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfe762fa0d105b6719f98ebf5f0858e161d36f8c

commit dfe762fa0d105b6719f98ebf5f0858e161d36f8c
Author: kylechar <kylechar@chromium.org>
Date: Mon Feb 26 17:00:01 2018

viz: Move FakeOutputSurface + dependencies.

This CL moves test classes from cc/test to components/viz/test. The main
classes being moved are implementations of viz types and belong in
components/viz/test.

1. FakeOutputSurface
2. TestContextProvider
3. TestContextSupport

There are a number of ancillary classes that also need to be moved.
These classes are test implementations of gpu types. The dependency
structure, where cc:test_support depends on components/viz/test,
requires the classes be moved also. It's likely the base gpu types will
eventually be moved to components/viz/service/gpu in the future.

1. OrderedTextureMap
2. TestGLES2Interface
3. TestTexture
4. TestWebGraphicsContext3D

Bug:  814475 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic1fdb0262b222b6cf6054621ef8647f63ee26bcd
Reviewed-on: https://chromium-review.googlesource.com/934624
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539169}
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/BUILD.gn
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/layers/nine_patch_layer_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/layers/surface_layer_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/paint/BUILD.gn
[add] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/paint/DEPS
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/raster/scoped_gpu_raster_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/raster/staging_buffer_pool_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/resources/layer_tree_resource_provider_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/test/DEPS
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/test/layer_tree_test.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/test/layer_tree_test.h
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/tiles/picture_layer_tiling_set_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/tiles/picture_layer_tiling_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/client/client_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/client/hit_test_data_provider_draw_quad_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/common/gpu/context_cache_controller_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/display_perftest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/gl_renderer_copier_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/shader_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display/texture_deleter_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/display_embedder/buffer_queue_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/BUILD.gn
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/DEPS
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/fake_output_surface.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/fake_output_surface.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/ordered_texture_map.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/ordered_texture_map.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_context_provider.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_context_provider.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_context_support.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_context_support.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_gles2_interface.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_gles2_interface.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_texture.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_texture.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_web_graphics_context_3d.cc
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_web_graphics_context_3d.h
[rename] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/components/viz/test/test_web_graphics_context_3d_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/media/blink/DEPS
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/dfe762fa0d105b6719f98ebf5f0858e161d36f8c/ui/aura/test/aura_test_context_factory.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0631f097b255b369e277b3348f6d0b2dcb4b705b

commit 0631f097b255b369e277b3348f6d0b2dcb4b705b
Author: kylechar <kylechar@chromium.org>
Date: Tue Feb 27 00:18:21 2018

viz: Add FrameSinkManagerImpl tests

Add tests to FrameSinkManagerTest that exercise the OOP-D code path that
use CreateRootCompositorFrameSink() and CreateCompositorFrameSink().

Call CreateRootCompositorFrameSink() needs a DisplayProvider
implementation, so add TestDisplayProvider that creates a Display with
a FakeOutputSurface.

Bug:  814475 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0bfef35d8bcf0c513307b371422e134f06f6aaaf
Reviewed-on: https://chromium-review.googlesource.com/938160
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539331}
[modify] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/common/BUILD.gn
[add] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/common/constants.cc
[add] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/common/constants.h
[modify] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/common/switches.cc
[modify] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/test/BUILD.gn
[add] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/test/test_display_provider.cc
[add] https://crrev.com/0631f097b255b369e277b3348f6d0b2dcb4b705b/components/viz/test/test_display_provider.h
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5736130ab6358e0b45bd871f1bcec90f1066c221

commit 5736130ab6358e0b45bd871f1bcec90f1066c221
Author: kylechar <kylechar@chromium.org>
Date: Thu Apr 05 03:15:06 2018

Change CompositorFrameSink connection loss.

1. Remove the OnClientConnectionClosed() IPC from GPU to browser.  The
   browser never used the IPC so it wasn't necessary.
2. Destroy CompositorFrameSinkImpl when the client connection is closed.
   The object is useless after that point so it can be cleaned up.
3. Don't destroy RootCompositorFrameSinkImpl when the client connection
   is closed. The display compositor will continue to produce frames.

Bug:  814475 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie9a96ee504013435c23b05cf6dbaa3fda4e0fd33
Reviewed-on: https://chromium-review.googlesource.com/993993
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548305}
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/compositor_frame_sink_impl.h
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/test/mock_compositor_frame_sink_client.h
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/components/viz/test/test_frame_sink_manager_client.h
[modify] https://crrev.com/5736130ab6358e0b45bd871f1bcec90f1066c221/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom

Comment 8 by kylec...@chromium.org, Apr 5 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment