New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814474 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 780078



Sign in to add a comment

Rename U2fBleDevice and related class to FidoBleDevice

Project Member Reported by hongjunchoi@chromium.org, Feb 21 2018

Issue description

CTAP and U2F protocol share same BLE transport specification. Rename U2F BLE related constructs to have Fido as prefix and consolidate shared constants. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1710f5adcfb6820a4da2e49407b93730454c3e41

commit 1710f5adcfb6820a4da2e49407b93730454c3e41
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Fri Mar 16 21:09:19 2018

Rename prefix for BLE related classes to FIDO

U2F and CTAP share same BLE GATT service UUID and service
characteristics. Furthermore, BLE transport specification for CTAP is a
strict superset of U2F BLE transport specifications. All transport
specifications including fragmentation, request, and response
structure are the same. CTAP protocol simply  adds cancel command to the
list of commands. Rename all Ble related objects to have Fido as prefix.

Bug:  814474 
Change-Id: I1978e4b536337e97311cb8c651a8d95256a75c6e
Reviewed-on: https://chromium-review.googlesource.com/929805
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543829}
[modify] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/BUILD.gn
[modify] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/BUILD.gn
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_connection.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_connection.h
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_connection_unittest.cc
[add] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_device.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_device.h
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_device_unittest.cc
[add] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_discovery.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_discovery.h
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_discovery_unittest.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_frames.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_frames.h
[add] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_frames_fuzzer.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_frames_unittest.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_transaction.cc
[add] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_ble_transaction.h
[modify] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/fido_discovery.cc
[add] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/mock_fido_ble_connection.cc
[rename] https://crrev.com/1710f5adcfb6820a4da2e49407b93730454c3e41/device/fido/mock_fido_ble_connection.h
[delete] https://crrev.com/1963d5c682b509bd36b8636cd4bea7b822e4eaf9/device/fido/mock_u2f_ble_connection.cc
[delete] https://crrev.com/1963d5c682b509bd36b8636cd4bea7b822e4eaf9/device/fido/u2f_ble_device.cc
[delete] https://crrev.com/1963d5c682b509bd36b8636cd4bea7b822e4eaf9/device/fido/u2f_ble_discovery.cc
[delete] https://crrev.com/1963d5c682b509bd36b8636cd4bea7b822e4eaf9/device/fido/u2f_ble_frames_fuzzer.cc
[delete] https://crrev.com/1963d5c682b509bd36b8636cd4bea7b822e4eaf9/device/fido/u2f_ble_transaction.h

Status: Fixed (was: Assigned)

Sign in to add a comment