New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814467 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Passing None to the wifi connect prevents it from working

Project Member Reported by haddowk@chromium.org, Feb 21 2018

Issue description



Somehow the None is getting through the to the command line.

The setting is correct

[MOBLAB]
wifi_dut_ap_name = GoogleGuest


But the None is getting through to the test.

02/21 13:00:34.868 INFO |     tradefed_test:0794| RUN: /usr/local/autotest/cros/scripts/wifi connect GoogleGuest None

 
Owner: haddowk@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b5b377277110180ea986e12c0b2e3b7c64e1102c

commit b5b377277110180ea986e12c0b2e3b7c64e1102c
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Feb 23 07:54:10 2018

[moblab] Change the default wifi password to ''

Currnetly if there is no wifi password configured we are passing
the string None as the password change to empty string.

TEST=built fizz moblab
BUG= chromium:814467 

Change-Id: I6d3b99ae636cb7c183283b45bd6bc4122508955b
Reviewed-on: https://chromium-review.googlesource.com/932543
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/b5b377277110180ea986e12c0b2e3b7c64e1102c/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/db653119ed60e2d20882ee3fd96fd68ed5a02e7d

commit db653119ed60e2d20882ee3fd96fd68ed5a02e7d
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Feb 23 07:59:42 2018

[moblab] Change the default wifi password to ''

Currnetly if there is no wifi password configured we are passing
the string None as the password change to empty string.

TEST=built fizz moblab
BUG= chromium:814467 

Change-Id: I6d3b99ae636cb7c183283b45bd6bc4122508955b
Reviewed-on: https://chromium-review.googlesource.com/932543
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit b5b377277110180ea986e12c0b2e3b7c64e1102c)
Reviewed-on: https://chromium-review.googlesource.com/933708
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/db653119ed60e2d20882ee3fd96fd68ed5a02e7d/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/42fc37e775cb2a4b15f4f9c015c51fcbb2009334

commit 42fc37e775cb2a4b15f4f9c015c51fcbb2009334
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Feb 23 07:59:45 2018

[moblab] Change the default wifi password to ''

Currnetly if there is no wifi password configured we are passing
the string None as the password change to empty string.

TEST=built fizz moblab
BUG= chromium:814467 

Change-Id: I6d3b99ae636cb7c183283b45bd6bc4122508955b
Reviewed-on: https://chromium-review.googlesource.com/932543
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit b5b377277110180ea986e12c0b2e3b7c64e1102c)
Reviewed-on: https://chromium-review.googlesource.com/933707
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/42fc37e775cb2a4b15f4f9c015c51fcbb2009334/frontend/afe/moblab_rpc_interface.py

Status: Fixed (was: Started)

Sign in to add a comment