New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814463 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 810128



Sign in to add a comment

get viz hit-test working on android

Project Member Reported by riajiang@chromium.org, Feb 21 2018

Issue description

(as summary)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d89b7055ee11400714bccd8a226bc182aa2e17f5

commit d89b7055ee11400714bccd8a226bc182aa2e17f5
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu Feb 22 05:36:26 2018

Pass along hit-test data on android.

Pass along hit-test data in RenderWidgetHostViewAndroid::
SubmitCompositorFrame and DelegatedFrameHostAndroid::
SubmitCompositorFrame.

Bug:  814463 
Test: https://chromium-review.googlesource.com/c/chromium/src/+/919260
Change-Id: I704f44bb9be8d51f416df197eb815f8e2ec6a51f
Reviewed-on: https://chromium-review.googlesource.com/929865
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538359}
[modify] https://crrev.com/d89b7055ee11400714bccd8a226bc182aa2e17f5/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/d89b7055ee11400714bccd8a226bc182aa2e17f5/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/d89b7055ee11400714bccd8a226bc182aa2e17f5/ui/android/delegated_frame_host_android.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e8e346126080084adae743efe6f9fc15004d102

commit 0e8e346126080084adae743efe6f9fc15004d102
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu Feb 22 23:02:01 2018

Get the root FrameSinkId in RenderWidgetHostViewAndroid.

Override RenderWidgetHostViewBase::GetRootFrameSinkId() to return the
FrameSinkId of the root surface on android.

Bug:  814463 
Test: https://chromium-review.googlesource.com/c/chromium/src/+/919260
Change-Id: I6749ab27874749c695c7469e4f48859cf1b0515b
Reviewed-on: https://chromium-review.googlesource.com/929360
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538605}
[modify] https://crrev.com/0e8e346126080084adae743efe6f9fc15004d102/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/0e8e346126080084adae743efe6f9fc15004d102/content/browser/renderer_host/render_widget_host_view_android.h

Status: Fixed (was: Started)

Sign in to add a comment