New issue
Advanced search Search tips

Issue 814443 link

Starred by 1 user
Status: Fixed
Owner:
etienneb@chromium.org
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Slow-reports traces are not longer parsable by diff_heap+dump

Project Member Reported by etienneb@chromium.org, Feb 21 2018 
Chrome traces with memory dumps uploaded by slow-reports are no longer parsable by the diff_heap_dump tools.

This is due to stripping the strings to anonymize the data.
The process names got replaced by "__stripped__" which is breaking the parser which is assuming and dictionary.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/cee7176ed9effe5643cafdf7ab5cbb01715c522d

commit cee7176ed9effe5643cafdf7ab5cbb01715c522d
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Wed Feb 21 22:22:24 2018

Fix parsing of stripped traces from slow-reports

This CL is fixing the trace parser to avoid crashing the process names
are stripped.

Bug:  chromium:814443 
Change-Id: Ie62faa5bab61e548474b044275923f8970d5a48f
Reviewed-on: https://chromium-review.googlesource.com/929606
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>

[modify] https://crrev.com/cee7176ed9effe5643cafdf7ab5cbb01715c522d/experimental/tracing/bin/diff_heap_profiler.py

Comment 2 by etienneb@chromium.org, Feb 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment