New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814421 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q1

Blocking:
issue 818198



Sign in to add a comment

Generate PNG assets for Tab Grid Cells

Project Member Reported by rohitrao@chromium.org, Feb 21 2018

Issue description

We require image (PNG) assets for the Tab Grid.  These will be full-color icons and therefore will *not* be used as template images.

Please generate @1x, @2x, and @3x resolutions for each asset.  Please include pressed and disabled states if they are appropriate.

Each asset is listed along with its desired filename prefix.

(prefix).png
(prefix)@2x.png
(prefix)@3x.png
(prefix)_pressed.png
(prefix)_pressed@2x.png
(prefix)_pressed@3x.png
(prefix)_disabled.png
(prefix)_disabled@2x.png
(prefix)_disabled@3x.png

I do not believe that any of the below assets will be different between regular and compact size classes.  If that assumption is incorrect, please let me know.

I do not believe that any of the below assets will be different between phone and tablet.  If that assumption is incorrect, please let me know.


Tab Grid Assets:
tabgrid_tab_close             - Close button for normal tabs
tabgrid_tab_close_incognito   - Close button for incognito tabs
tabgrid_favicon_background    - The white-ish rounded rect to be composited behind favicons
tabgrid_new_tab               - The blue new tab button in compact portrait
tabgrid_new_tab_incognito     - The white new incognito tab button in compact portrait
tabgrid_new_tab_fab           - The blue new tab floating action button
tabgrid_new_tab_fab_incognito - The white new incognito tab floating action button

Tab Grid Colors, Sizes, and Fonts:
- tabgrid background color
- tab title background color (normal)
- tab title background color (incognito)
- tab title font
- tab thin line below title thickness
- tab thin line below title color (normal)
- tab thin line below title color (incognito)
- tab title text color (normal)
- tab title text color (incognito)
- tab cell rounded rect radius
- tab selection border thickness
- tab selection border distance from tab
- tab selection border color (normal)
- tab selection border color (incognito)
- top and bottom toolbar background color
- top and bottom toolbar button text color
- top and bottom toolbar heights
- top and bottom toolbar text button margins from the edge
- top and bottom toolbar fonts
- default background color for tab cells (if the snapshot is missing or still loading)
- default background color for incognito tab cells (if the snapshot is missing or still loading)
- redlines that show cell placement in compact portrait
- redlines that show cell placement in compact landscape
- redlines that show cell placement in regular portrait
- redlines that show cell placement in regular landscape
- redlines that show cell placement in tablet split screen 1/3 screen
- redlines that show cell placement in tablet split screen 1/2 screen

 

Comment 1 by edchin@chromium.org, Feb 23 2018

Labels: MS-Tab-Grid

Comment 2 by edchin@chromium.org, Feb 23 2018

Description: Show this description

Comment 3 by edchin@chromium.org, Feb 23 2018

Description: Show this description

Comment 4 by edchin@chromium.org, Feb 23 2018

Description: Show this description
NextAction: 2018-03-09
Blocking: 818198

Comment 7 by cmasso@google.com, Mar 6 2018

Is this still on track for 3/9?
Yep. Should have an update in the next couple days :)
The NextAction date has arrived: 2018-03-09
Status: Fixed (was: Assigned)
Updated spec to include split screen layouts: https://folio.googleplex.com/ntp/Tab%20Grid#%2Ftab_grid.html

Hey Khalil, I need a few more items. Can you get me these?

- bottom toolbar round button regular PNG
- bottom toolbar round button incognito PNG
- bottom toolbar round button disabled (gray) PNG
- floating button disabled (gray) PNG

cmasso@, should we continue to track followups on this crbug? 
Please disregard the last item "-floating button disabled (gray) PNG". There is no such thing in the mocks. 
My mistake. I have all the toolbar assets. 

Comment 15 by cmasso@google.com, Mar 14 2018

NextAction: ----
Labels: Proj-UIRefresh

Sign in to add a comment