New issue
Advanced search Search tips

Issue 814418 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Add LayoutTests to test privacy guarantee for timeouts / NOT_ALLOWED_ERROR

Project Member Reported by kpaulhamus@chromium.org, Feb 21 2018

Issue description

Assert that WebAuthN operations that either return NOT_ALLOWED_ERROR or timeout are indistinguishable to prevent privacy leaks.

Dependent on software security key.
 

Comment 1 by engedy@chromium.org, Mar 31 2018

Cc: agl@chromium.org
Labels: M-67 Pri-2
Would be nice to have, but not quite sure how to reliably test whether a request "would time out" without actually letting in time out. Ideas are welcome.

Comment 2 by engedy@chromium.org, Mar 31 2018

Labels: Hotlist-WebAuthnFixit
The only thing that comes to mind - setup a normal timeout test (like the one that verifies the timeout works) and issue all the requests that should definitely return NOT_ALLOWED_ERROR and verify the error wasn't returned until we deliberately trigger the timeout.
...basically, extending the existing timeout tests to cover all NOT_ALLOWED_ERROR cases. Beyond that I'm not sure what we could do.
Do you mean external/wpt/webauthn/createcredential-timeout.https.html? I am afraid I removed all the other timeout-based tests. Maybe we can let the Testing API fast-forward time somehow, but I will have to think about the details.


Oh, hm I guess I was thinking of the timeout unit tests here:
https://cs.chromium.org/chromium/src/content/browser/webauth/authenticator_impl_unittest.cc
Not quite the same thing..
Seems likely we could do this in browser tests. Not sure about layout tests.
Looked into this further and I don't think this is possible. Should we close this out?

Comment 8 by engedy@chromium.org, Apr 13 2018

Status: WontFix (was: Assigned)
Yeah, let's have unit tests with mockable time.

Sign in to add a comment