New issue
Advanced search Search tips

Issue 814408 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cros splitscreen - Windows are in wrong position after rotation

Project Member Reported by x...@chromium.org, Feb 21 2018

Issue description

Chrome Version: 66.0.3351.0
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Put two windows in split screen in primary landscape, say left window and right window
(2) Rotate the device to primary portrait

Expected result:
The left window should be on bottom side of the screen, and the right window should be on top side of the screen

Actual result:
The left window should be on top side of the screen, and the right window should be on bottom side of the screen


 

Comment 1 by minch@chromium.org, Feb 22 2018

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d73c9eb4552a4540b4cd8eab1866538cb2c6617

commit 9d73c9eb4552a4540b4cd8eab1866538cb2c6617
Author: MinChen <minch@chromium.org>
Date: Thu Mar 01 04:00:49 2018

cros splitscreen: Adjust the snapped window position according to the new
screen orientation.

We changed the default portrait screen orientation in a previous cl
(https://chromium-review.googlesource.com/c/chromium/src/+/877441).
This cl adjusts the splitscreen snapped windows' position in portrait
orientation according to the change.

Bug:  814408 
Change-Id: I805a7eed6763b71ed7e534dd27b7b30a5768852e
Reviewed-on: https://chromium-review.googlesource.com/932321
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540035}
[modify] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/ash/wm/splitview/split_view_overview_overlay.cc

Comment 3 by minch@chromium.org, Mar 1 2018

Status: Fixed (was: Started)

Comment 4 by x...@chromium.org, Mar 7 2018

 Issue 795862  has been merged into this issue.

Sign in to add a comment