New issue
Advanced search Search tips

Issue 814405 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocking:
issue 838650



Sign in to add a comment

Swarm cts tests

Project Member Reported by hzl@chromium.org, Feb 21 2018

Issue description

Swarm upstream cts tests bots and add swarmed cts tests into downstream testers.
 
Components: Infra>Client>Chrome
Labels: OS-Android

Comment 2 by hzl@chromium.org, Feb 23 2018

also add it to test-n-tablet.
Blocking: 838650
Labels: -Pri-3 Pri-2
Blockedon: 867085
Issue 867085 has been merged into this issue.
Blockedon: -867085
Components: Mobile>WebView
Owner: ----
Status: Available (was: Assigned)
Rebase this cl: https://chromium-review.googlesource.com/c/chromium/src/+/905942 with Andrew's cl in comment 8.
Owner: aluo@chromium.org
Status: Assigned (was: Available)
can't see who the previous owner was but isn't aluo@ working on this?
Thanks Paul, yes thanks for updating the owner.
Labels: Type-Task
Bulk move tasks.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9db92e435dd93318e8de36f087168db0247a1a82

commit 9db92e435dd93318e8de36f087168db0247a1a82
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Oct 04 04:50:48 2018

Run webview shell instrumentation tests as gtests on WebView L.

TBR=aluo@chromium.org

Bug: 814405
Change-Id: I0daf53d6e5784d5f476d804e4c13dcc2c35ba5c5
Reviewed-on: https://chromium-review.googlesource.com/c/1260385
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596505}
[modify] https://crrev.com/9db92e435dd93318e8de36f087168db0247a1a82/testing/buildbot/chromium.android.json
[modify] https://crrev.com/9db92e435dd93318e8de36f087168db0247a1a82/testing/buildbot/waterfalls.pyl

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc37498b28ce3c868f8312230baad6b2e7543f6

commit 7fc37498b28ce3c868f8312230baad6b2e7543f6
Author: Andrew Luo <aluo@chromium.org>
Date: Thu Oct 04 18:16:08 2018

Fix cipd install path for webview cts

Bug: 814405
Change-Id: I05c8e2d36ff5a5e0328921917e4cd5c55427d54a
Reviewed-on: https://chromium-review.googlesource.com/c/1261915
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596758}
[modify] https://crrev.com/7fc37498b28ce3c868f8312230baad6b2e7543f6/testing/buildbot/chromium.android.json
[modify] https://crrev.com/7fc37498b28ce3c868f8312230baad6b2e7543f6/testing/buildbot/test_suites.pyl

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb250616a7251d105e25d3e9422bb8ab0e6ce087

commit bb250616a7251d105e25d3e9422bb8ab0e6ce087
Author: Andrew Luo <aluo@chromium.org>
Date: Thu Oct 04 21:46:21 2018

Fix arg name of the isolated script results file

Bug: 814405
Change-Id: I55b8c06553a45c24a5527bc5b482d19d9d76fd8f
Reviewed-on: https://chromium-review.googlesource.com/c/1262915
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596870}
[modify] https://crrev.com/bb250616a7251d105e25d3e9422bb8ab0e6ce087/android_webview/tools/run_cts.py

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eea29efe183742b34fb94040423a0e789a6a34f1

commit eea29efe183742b34fb94040423a0e789a6a34f1
Author: Andrew Luo <aluo@chromium.org>
Date: Fri Oct 05 06:16:10 2018

Uninstall webview before running cts test and don't run shell instrumentation test on swarming for now.
Bug: 814405
Change-Id: Icdd9f5f68679d3483d2b329f18a7b820ae500d0e
Reviewed-on: https://chromium-review.googlesource.com/c/1264155
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597009}
[modify] https://crrev.com/eea29efe183742b34fb94040423a0e789a6a34f1/testing/buildbot/chromium.android.json
[modify] https://crrev.com/eea29efe183742b34fb94040423a0e789a6a34f1/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/eea29efe183742b34fb94040423a0e789a6a34f1/testing/buildbot/waterfalls.pyl

Still need to take care of device provisioning to grant geolocation permissions.  I'm thinking of just turning provision_devices.py into a wrapper like system_app.py
provision_devices can take quite a bit of time. If it's straightforward enough, you might want to add the permissions directly to swarming's provisioning:
https://chrome-internal.googlesource.com/infradata/config/+/master/configs/chromium-swarm-dev/scripts/android.py#55

Though I'm not sure what enabling geo permissions entails.

Sign in to add a comment