New issue
Advanced search Search tips

Issue 814403 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mash_browser_tests doesn't run on the LSan bot

Project Member Reported by jamescook@chromium.org, Feb 21 2018

Issue description

Specifically, it's excluded in test_suite_exceptions.pyl:

      # chromium.memory
      'Linux Chromium OS ASan LSan Tests (1)',

I'm not sure why. Maybe timeouts?

 
Ditto mash_ash_unittests.

Components: -Internals>MUS Internals>Services>WindowService
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3695968a8414ad39402dd8c275e53155d170023

commit d3695968a8414ad39402dd8c275e53155d170023
Author: Nico Weber <thakis@chromium.org>
Date: Thu Apr 12 03:33:46 2018

Remove many chromium.memory exceptions.

If we run tests on the main waterfall, we generally should run them
on the memory waterfall as well.

I filed bugs and added comments to those for the few tests that
actually don't pass on the memory waterfall. Most do pass.

Bug: 814403,831667,831674,831676,830653
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0ea3cf12745f089d7fb87da8fc20e2665d86d53f
Reviewed-on: https://chromium-review.googlesource.com/987916
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550005}
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/ui/gl/gl_context_glx_unittest.cc
[modify] https://crrev.com/d3695968a8414ad39402dd8c275e53155d170023/ui/gl/gl_image_shared_memory_unittest.cc

Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcc66e1cabf73611a7b5d6aeacb097f7094645f2

commit fcc66e1cabf73611a7b5d6aeacb097f7094645f2
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sun Jul 01 00:15:13 2018

Revert "Remove several test suppressions where it is not clear why they exist."

This reverts commit 774a04848a634b053c5539b214c8878c5407d086.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 571782 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc3NGEwNDg0OGE2MzRiMDUzYzU1MzliMjE0Yzg4NzhjNTQwN2QwODYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac%20Builder/88620

Sample Failed Step: compile

Original change's description:
> Remove several test suppressions where it is not clear why they exist.
> 
> If any of these fail on their bots, I'll file dedicated bugs for that
> and re-disable with a link to the bug.
> 
> Bug: 843511,830944,814403
> Change-Id: Ib1beb2fc1ffcade39535b47b25b50340131092e5
> Reviewed-on: https://chromium-review.googlesource.com/1121524
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571782}

Change-Id: I007c8f0090be2e7162f0ef32c22b04e08886067b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843511,830944,814403
Reviewed-on: https://chromium-review.googlesource.com/1121796
Cr-Commit-Position: refs/heads/master@{#571783}
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/chromium.win.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/fcc66e1cabf73611a7b5d6aeacb097f7094645f2/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89a3c914eeeaa4bcf16196b92304853757e0584

commit e89a3c914eeeaa4bcf16196b92304853757e0584
Author: Nico Weber <thakis@chromium.org>
Date: Sun Jul 01 01:30:52 2018

Reland "Remove several test suppressions where it is not clear why they exist."

This is a reland of 774a04848a634b053c5539b214c8878c5407d086

Original change's description:
> Remove several test suppressions where it is not clear why they exist.
> 
> If any of these fail on their bots, I'll file dedicated bugs for that
> and re-disable with a link to the bug.
> 
> Bug: 843511,830944,814403
> Change-Id: Ib1beb2fc1ffcade39535b47b25b50340131092e5
> Reviewed-on: https://chromium-review.googlesource.com/1121524
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571782}

Bug: 843511, 830944, 814403
Change-Id: I8ea5586d15446108a5d18b93686f64e0c4140559
Reviewed-on: https://chromium-review.googlesource.com/1121836
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571786}
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/chromium.win.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/e89a3c914eeeaa4bcf16196b92304853757e0584/testing/buildbot/test_suite_exceptions.pyl

Sign in to add a comment