Redundant expectations in webrtc_logging_private_apitest.cc |
||
Issue descriptionIn webrtc_logging_private_apitest.cc, RunFunction() EXPECT-s and return-s whether the function returns a result. Most tests then perform a redundant assertion/expectation on the same thing.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d3d012ac811a47558c9b519769a6346014278c3 commit 6d3d012ac811a47558c9b519769a6346014278c3 Author: Elad Alon <eladalon@chromium.org> Date: Fri Apr 06 10:13:21 2018 Remove redundant expectations from webrtc_logging_private_apitest.cc RunFunction() was verifying whether a value was returned, then the test bodies were also verifying the same thing. This CL fixes. Bug: 814402 Change-Id: I177053ee53d1f651ad0cda986b78148759ddcea9 Reviewed-on: https://chromium-review.googlesource.com/986266 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548732} [modify] https://crrev.com/6d3d012ac811a47558c9b519769a6346014278c3/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
,
Apr 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by eladalon@chromium.org
, Apr 5 2018