New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814372 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

update_client::TestConfigurator should use TestConnectorfactory

Project Member Reported by jcivelli@chromium.org, Feb 21 2018 
update_client::TestConfigurator should use TestConnectorfactory instead of mocking the connector.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa9caa8e79616638d4eec09cbdc9606f9d0ea39

commit caa9caa8e79616638d4eec09cbdc9606f9d0ea39
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Feb 26 17:42:11 2018

Change TestConfigurator to use TestConnectorFactory

Now that service_manager::TestConnectorFactory supports multiple
services, changes TestConfigurator to use it.

Bug:  814372 
Change-Id: I04647c81616d993b7c8486b83c2e84a4217b4f70
Reviewed-on: https://chromium-review.googlesource.com/929015
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539185}
[modify] https://crrev.com/caa9caa8e79616638d4eec09cbdc9606f9d0ea39/components/update_client/BUILD.gn
[modify] https://crrev.com/caa9caa8e79616638d4eec09cbdc9606f9d0ea39/components/update_client/test_configurator.cc
[modify] https://crrev.com/caa9caa8e79616638d4eec09cbdc9606f9d0ea39/components/update_client/test_configurator.h

Comment 2 by jcivelli@chromium.org, Feb 26 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment