DeviceWallpaperImage has it's external data downloader. A generic downloader and manager was written for DeviceNativePrinters. Migrate the wallpaper image policy once the downloader has been stabilized.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e020e89e360f170c81aa5fd9eed4e1543dad14e6 commit e020e89e360f170c81aa5fd9eed4e1543dad14e6 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Wed Jan 16 08:57:53 2019 Migrate ExternalDataFetcher to BindOnce() and OnceCallbacks. Bug: 814364 Change-Id: I101a1402cf8d8320e76f0116e2dc2ed9f4986e76 Reviewed-on: https://chromium-review.googlesource.com/c/1406714 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#623161} [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/cloud_external_data_manager_base.h [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/device_policy_cloud_external_data_manager_browsertest.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/components/policy/core/common/cloud/mock_cloud_external_data_manager.h [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/components/policy/core/common/external_data_fetcher.cc [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/components/policy/core/common/external_data_fetcher.h [modify] https://crrev.com/e020e89e360f170c81aa5fd9eed4e1543dad14e6/components/policy/core/common/external_data_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/488dbae09969e27209274d8dbaca1fc3716d3b60 commit 488dbae09969e27209274d8dbaca1fc3716d3b60 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Sat Jan 19 01:18:42 2019 Add path of the file with fetched data in external data policy pipeline. It will be mostly used by CloudExternalDataPolicyObserver::Delegate and DeviceCloudExternalDataPolicyObserver::Delegate, which are the end point of the pipeline. This will be used to migrate DeviceWallpaperImage policy from custom downloader to existing pipeline in upcoming CL. Bug: 814364 Change-Id: I4f87823cb5495c6c880493a76719b94dfeb8bb99 Reviewed-on: https://chromium-review.googlesource.com/c/1403128 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#624398} [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_store.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_store.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/cloud_external_data_store_unittest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer_browsertest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_native_printers_handler.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_native_printers_handler.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_native_printers_handler_unittest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/device_policy_cloud_external_data_manager_browsertest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/cloud/component_cloud_policy_store.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/cloud/resource_cache.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/cloud/resource_cache.h [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/cloud/resource_cache_unittest.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/external_data_fetcher.cc [modify] https://crrev.com/488dbae09969e27209274d8dbaca1fc3716d3b60/components/policy/core/common/external_data_fetcher.h
Comment 1 by ovanieva@chromium.org
, Feb 23 2018