Add a histogram reporting convertible devices' hinge angles |
||
Issue descriptionI don't think we have a histogram reporting the time spent at different hinge angles on convertible devices, but having this would help greatly in guiding UX decisions. This seems easy to collect -- just start a timer and periodically (every 15 minutes? every hour?) report the angle.
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbadc7c134b42429b5c1be96d289037980357e7f commit fbadc7c134b42429b5c1be96d289037980357e7f Author: Daniel Erat <derat@chromium.org> Date: Tue Feb 27 03:53:27 2018 ash: Report Ash.TouchView.LidAngle histogram. Update ash::TabletModeController to report a new histogram containing the computed lid angle once per hour. (Note that the computed angle is often inaccurate by tens of degrees.) Also change "tabletmode" in a few members to "tablet_mode" (this looks like an earlier search-and-replace bug) and initialize POD members in the header. Bug: 814363 Change-Id: I5066fb6e859a34343506f88453845156186b81b3 Reviewed-on: https://chromium-review.googlesource.com/933732 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Qiang Xu <warx@google.com> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#539396} [modify] https://crrev.com/fbadc7c134b42429b5c1be96d289037980357e7f/ash/wm/tablet_mode/tablet_mode_controller.cc [modify] https://crrev.com/fbadc7c134b42429b5c1be96d289037980357e7f/ash/wm/tablet_mode/tablet_mode_controller.h [modify] https://crrev.com/fbadc7c134b42429b5c1be96d289037980357e7f/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc [modify] https://crrev.com/fbadc7c134b42429b5c1be96d289037980357e7f/tools/metrics/histograms/histograms.xml
,
Feb 27 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Feb 22 2018