Media Engagement: send UKM event when "IsHigh" status changes |
|||||
Issue descriptionIt will incorporate a status metric providing the type of change.
,
Feb 28 2018
,
Mar 15 2018
Following up from a discussion hbengali@ and I had yesterday, it sounds that we want something different. To give some context, initially, my understanding was that we wanted a count so the UKM computation could just look at it. I did not want to keep track of it so I suggested to just have a boolean that is on *when* there is a change. Then, I realised it wouldn't be much work to do the counting, talked to hbengali about it and agreed on how it should work. Finally, it seems that the counting is more pain than help and the solution should be to have a IsHighChanged boolean that is 1 when the UKM event created an IsHigh status change. We should try to land this soon and see if we can merge.
,
Mar 15 2018
,
Apr 9 2018
Privacy LGTM.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/902f59aca1722a518d4da15524bc55623670c8ea commit 902f59aca1722a518d4da15524bc55623670c8ea Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Apr 09 19:34:44 2018 Media Engagement: Add a UKM bit if the session changed isHigh This adds an Engagement.IsHigh.Changed bit to the SessionFinished UKM that will be true if the IsHigh bit changed during the lifetime of the session. BUG= 814351 Change-Id: I48b296301a59d7f92ce6fd8ac7750c41ed2bbecd Reviewed-on: https://chromium-review.googlesource.com/964181 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#549242} [modify] https://crrev.com/902f59aca1722a518d4da15524bc55623670c8ea/chrome/browser/media/media_engagement_score.h [modify] https://crrev.com/902f59aca1722a518d4da15524bc55623670c8ea/chrome/browser/media/media_engagement_session.cc [modify] https://crrev.com/902f59aca1722a518d4da15524bc55623670c8ea/chrome/browser/media/media_engagement_session.h [modify] https://crrev.com/902f59aca1722a518d4da15524bc55623670c8ea/chrome/browser/media/media_engagement_session_unittest.cc [modify] https://crrev.com/902f59aca1722a518d4da15524bc55623670c8ea/tools/metrics/ukm/ukm.xml
,
Apr 9 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 28 2018