We've gotten two additional feedback reports from users on Chrome OS that spellcheck is not working on M65 Beta (65.0.3325.65 beta).

https://listnr.corp.google.com/product/208/report/85089468847
https://listnr.corp.google.com/product/208/report/85089549816

Both users are have country set to GB and language set as English (United Kingdom),

Works in CrOS 10032.86.0 w/ 63.0.3239.140

I'm somewhat puzzled how rschoen's OS version is lower, but the Chrome version is higher...

Anyways - could somebody bisect, please?

Also, +xiaocheng who has been doing a lot of spellcheck work recently.

Setting NextAction as a reminder so this doesn't get lost.

I'm having the same problem on a separate (but Chrome synced) Windows machine running 64.0.3282.186. Also, I checked a separate profile on the Chrome OS machine from where I originally reported this (so running the same OS/browser version) and it works just fine.

FWIW the problem profile is corp (@google.com) and the one working fine is my personal. I've verified the issue exists in incognito though, so it's not corp extensions (or any extensions).

I fixed the issue, but I'm incredibly confused.

I went to language settings, and found "Spell check" was disabled. This was separate from the "Use a web service to help resolve spelling errors" setting, which was turned on. There did not appear to be a way to turn on spellcheck from language settings.

However, right clicked on some text I was editing and went to Spellcheck, and found that while "Ask Google for suggestions" was checked, "Check the spelling of text fields was not." From there, I was able to turn it on which also enabled it in language settings.

So it works, but some thoughts:

1) It seems like spellcheck settings should not be split between two different places ("use service" vs whatever the language setting is)
2) If we do have it split between two places, it really seems like the "use service" setting should indicate that spellcheck in general is off, so that you can go to the other place to turn it on
3) If spellcheck is disabled in language settings, it seems like you should be able to turn it on there
4) Persistent settings in the context menu seems like an extremely hard place to discover these things, especially if that's actually the only place I can edit this setting
5) (very minor) We use all of spellcheck, spell check, and spell-check at various points in the product.

Ok, grumbling over. Ccing Tom so he can at least know my grumbles :)

I'm having a problem where Chrome's spellcheck got "disabled" and I have no idea how to enable it. On Canary 66.0.3353.2, my personal profile. I think it's profile specific because I started a new profile and spellcheck options work fine there. Not sure if this is my error or a bug.

Deleted: spellcheckdisabled.JPG 77.2 KB

	spellcheckdisabled.JPG 77.2 KB View Download

Unable to reproduce the issue on Win-10 using chrome beta version #65.0.3325.73.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Typed incorrect words in gmail compose box and comment box of crbug.com page.
2. Observed that the misspelled words got underlined in red.

Forwarding the issue to inhouse team to check the issue on a win-10 corp machine for further investigation.

Thanks...!!

Deleted: 814318.mp4 566 KB

	814318.mp4 566 KB View Download

The NextAction date has arrived: 2018-02-26

+macourteau who worked on adding a Spellcheck related policy, see https://chromium-review.googlesource.com/c/chromium/src/+/826185.

FWIW, if I set the SpellcheckEnabled policy locally (which is different than SpellCheckServiceEnabled policy), I do see a policy indicator icon (see screenshot).

Deleted: spellcheck_disabled_by_policy.png 5.6 KB

	spellcheck_disabled_by_policy.png 5.6 KB View Download

Unable to reproduce the issue on Windows 10 & Mac 10.13.3 using chrome reported version-65.0.3325.65 & beta-65.0.3325.88 as per C#0.

Tested in gmail compose box & CRbug site & observed red lines for the misspelled words.

Please find the attached screencast for reference.

Thanks..!

Deleted: Feb 27, 2018 11_01 AM.webm 3.1 MB

	Feb 27, 2018 11_01 AM.webm 3.1 MB View Download

Having this same issue on my Linux desktop. Excuse the different OS, I thought it might be a relevant bug to contribute my issues to. Frustrating.

Both Chromium Version 64.0.3282.119 (Developer Build) built on Debian 9.3, running on Debian 9.3 (64-bit) and Chrome Version 64.0.3282.186 (Official Build) (64-bit)...

Both with my profile and without.

Excuse any spelling errors ;)

Deleted: Selection_001.png 25.8 KB

	Selection_001.png 25.8 KB View Download

 Issue 816517  has been merged into this issue.

+Eli since he was making changes to spellcheck settings Rouslan as FYI

Happily, we're already planning to make a lot of the changes that Ryan suggested in #7 :) See mock here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr6w9qB9onQTLbzXQZK5E-Tt0

We are moving the "enhanced spell check" toggle underneath spell check settings on Windows/CrOS, so it should be easier to find.

#7 does not solve my issue. 

Deleted: Tooltip_004.png 26.4 KB

	Tooltip_004.png 26.4 KB View Download

I've split out comment #17 into  https://crbug.com/819643 , because it appears to be a separate issue.

Unable to reproduce this issue on Windows 10 with chrome #65.0.3325.146,

Test url: https://html.com/tags/textarea/

Steps followed :
1. disabled "Use a web service to help resolve spelling errors"
2. Disabled "Spell Check" under language settings and navigate to test url and type misspell words
2A. Observed that spell check is not working
3. Enabled "Spell Check" under language settings and navigate to test url and type misspell words
3A. Observed that spell check is working as expected



Since TE doesn't able to reproduce the issue adding TE-NeedsTriageHelp for further triage.

Few customers have reported the spell check issue after upgraded to version 64 and 65.
(It works ok on version 63)
-Both customers are not able to reproduce the issue on open network.
-Both customers have network restrictions. (Firewall rules)  
(Both customers are using Windows7)
We are still confirming the basic settings, but is there any change since version 64?

Which language are they using for spellcheck? We occasionally update spellcheck dictionaries, which need to be re-downloaded from our CDN. Example location that needs to be allowed in the firewall:

https://redirector.gvt1.com/edgedl/chrome/dict/en-US-8-0.bdic

If a firewall blocks this download, spellcheck will not work. We have medium term plans to add more verbose UX to let user know that a dictionary download failed. In the very long term, we also have plans to fall back to using the old dictionary when the new dictionary failed to download, but that's very far in the future.

I have an Android test device with Chrome signed into corp that's also experiencing spell check issues in 65.0.3325.109 stable.

Downgrading to Chrome 63 did not fix the issue though so it might not be a Chrome issue. Does the firewall issue also affect Android?

@rouslan: Why RVG? There seems to be nothing sensitive in here?

@groby: For https://screenshot.googleplex.com/Qn3rLnde0mw. Is it worth it?

@rlanday: as far as I know, Chrome does not have spellcheck on Android. Does it?

Yes, we do. Red underline support for the native system spell checker was added some time ago; I added support for the menu in M62, and support for phones that implement spell checking using SuggestionSpans (e.g. Samsung devices) in M63.

Someone filed a bug about the same issue I was seeing, claiming that spell checking is broken in Chrome for Android as of M65:
https://bugs.chromium.org/p/chromium/issues/detail?id=822452

I concluded that this is actually the result of an intentional Gboard change to not show the red underlines while the keyboard is open:
https://buganizer.corp.google.com/issues/71718023

@rouslan: It's on screenshot.googleplex.com - no access for non-Googlers anyways :)

Removing R-V-G

Recently I have been working on cases where the end users report spell-check failures. Here is what I found so far:

Most recent instance:
LOCAL:
OS:Windows 10
Chrome version : 64*
-spell check does not work (web spelling service disabled)
-spell check has only English(US) as set language
-Windows regional settings are on English(US)
-disabled spell check and enabled the web spelling service - does not work 

TEST:
-asked the user to create new managed user under his domain - used it to login on test VM (Win10 with Chrome 64*) and created new Chrome profile - confirmed spell check and the web service work properly (checked independently)
-guided the customer to create new Chrome profile and the test user did not have the spell check or the web spelling service working properly. 

Previous instance:
In the past I had similar scenario, the issue was not resolved. We tested:
-using Canary 66*
-re-installing the browser (clearing user data, clearing registry, resetting sync)
-in this case the cust had 2 separately affected Windows 7 machines  
-the set languages were English(US) and German(GER), and again worked on test VM and not on the cust environment 
-all of the above if for managed users and on the contrary, an @gmail.com user profile on the same Windows 7 machine and browser worked just fine 

I am unable to find pattern and will appreciate if someone can suggest what additional details may be helpful and I will do my best to gather them next time. 

I'm on beta Version 66.0.3359.66 (Official Build) beta (64-bit) on Mac OSX High Sierra, 

I get red underlines, but no suggestions. I've tried toggling ask google for suggestions and tried many different sites, I still don't get suggestions.

I am seeing this issue with Chrome Stable (66.0.3359.117) on corp issued Windows 10 Enterprise laptop. Let me know if you need the laptop to do a Bisect.

Thanks Anantha. 

Prudhvi, will stop by for trying a bisect.

As updated by Ryan at comment#7 and upon checking Anantha's machine the settings was disabled for some reason and I wasn't able to enable it in my brief time spent on her machine. 

+Yana to prioritize

Is it a correct summary to say that the issue at hand is being addressed by work mentioned in #c22 (to address failed downloads of a dictionary blocked by firewall) and #c16 (to put all spellcheck settings together in Language Settings) by rouslan@ and ewald@ respectively? Rouslan and Eli - are there work bugs tracking those efforts?

 Issue 841736  has been merged into this issue.

On the Chrome OS side, there's definitely a trend in reports about not being able to enable spell-check on M65 and later:

Googler: https://listnr.corp.google.com/report/85400093155
Googler: https://listnr.corp.google.com/report/85390075263
https://listnr.corp.google.com/product/208/report/85436352657

Users say that the option either isn't there or can't be enabled.

Language = en (vs. en-US) seems to be disproportionately represented in user reports about this issue.

1) I talked to Ryan today about the original issue he experienced and have more clarity now. His issue (and it appears the reports in c38) all seem related to a change that happened in M65. Spellcheck seems to be either disabled by default or disabled through right click on text field ->Spellcheck ->Uncheck "Check the spelling of text fields". The latter makes it impossible to toggle spellcheck settings in Settings->Languages->Spellcheck which makes 0 sense. 


+macourteau or xiaochengh@ - is this related to your changes?

2) The issue with dictionaries that fail to download is completely separate from this and fixed by  crbug.com/820456 .

3) I filed a bug to unify spellcheck settings, because the current state as Ryan notes is super confusing. We need to wait for changes related to c16 to land first. To follow progress see crbug.com/848536

macourteau - can you take a look please if the issue I describe is related to your change in https://chromium-review.googlesource.com/c/chromium/src/+/826185?

 Issue 848197  has been merged into this issue.

#40: none of my changes is relevant to corp policy, so I guess they are not related.

#40: I'll take a look

Thanks so much Marc-Antoine! Added mathp@ as FYI to follow along as well.

Also for gCon folks who are helping users troubleshoot the issue, for now the workaround is:

1. Go to any text field on the web (e.g. textarea.org is reliable) and type in something misspelled (e.g. "icland is an icland").
2. Right click and click on "Check the spelling of text fields".

This should turn on Spellcheck everywhere and make it toggle-able in Settings.

the thing is i have no "Check the spelling of text fields" available in
right clcik menu
[image: image.png]

#46: if you're on a Mac, the option would be in the Edit menu (see attached screenshot).

Deleted: Screen Shot 2018-06-05 at 14.23.58.png 70.2 KB

	Screen Shot 2018-06-05 at 14.23.58.png 70.2 KB View Download

i think turning off system spellchecker and reenabling this finally made it
work again :) !

It seems worse then I'm used to... like in this case I expect a suggestion from macine to machine: Perhaps it's using the Mac's built in spell checking? which wouldn't be consistent across my ChromeOS laptop, home Linux desktop and work Mac

Deleted: Screen Shot 2018-06-05 at 1.41.10 PM.png 28.7 KB

	Screen Shot 2018-06-05 at 1.41.10 PM.png 28.7 KB View Download

I have a fix out for review for #40, point 1): https://chromium-review.googlesource.com/c/chromium/src/+/1087678

At c49: Mac issues are not covered by this bug. You are right that Mac uses the OS spellcheck but in your case "asking Google for suggestions" may be failing due to  crbug.com/844126  which is fixed in the next release (M68).

At c50: TY very much.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b79fbf4d1fc58556fdce80100705e17ff81d04f6

commit b79fbf4d1fc58556fdce80100705e17ff81d04f6
Author: Marc-Antoine Courteau <macourteau@chromium.org>
Date: Thu Jun 07 14:09:36 2018

Fixes  crbug.com/814318  (spellcheck not functional):
- only disables the "spellcheck" section when spellchecking is disabled
  by policy, but not if disabled by the user;
- disables the context menu entry if spellcheck is enforced by policy.

Bug:  814318 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I26e22bbc945b1cfb89a80a362d1ead1503350e42
Reviewed-on: https://chromium-review.googlesource.com/1087678
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565253}
[modify] https://crrev.com/b79fbf4d1fc58556fdce80100705e17ff81d04f6/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
[modify] https://crrev.com/b79fbf4d1fc58556fdce80100705e17ff81d04f6/chrome/browser/resources/settings/languages_page/languages_page.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57e5107fc7c70eaa1c9910ed4eb59767008e071c

commit 57e5107fc7c70eaa1c9910ed4eb59767008e071c
Author: Kevin McNee <mcnee@chromium.org>
Date: Thu Jun 07 15:20:45 2018

Revert "Fixes  crbug.com/814318  (spellcheck not functional):"

This reverts commit b79fbf4d1fc58556fdce80100705e17ff81d04f6.

Reason for revert: CrSettingsLanguagesPageTest.Spellcheck is failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/9083 . Findit identified this CL.

Original change's description:
> Fixes  crbug.com/814318  (spellcheck not functional):
> - only disables the "spellcheck" section when spellchecking is disabled
>   by policy, but not if disabled by the user;
> - disables the context menu entry if spellcheck is enforced by policy.
> 
> Bug:  814318 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I26e22bbc945b1cfb89a80a362d1ead1503350e42
> Reviewed-on: https://chromium-review.googlesource.com/1087678
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565253}

TBR=avi@chromium.org,stevenjb@chromium.org,macourteau@chromium.org

Change-Id: I401ffbe57e1c9157c218c623b6fecce4ca00eee7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  814318 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1090950
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565270}
[modify] https://crrev.com/57e5107fc7c70eaa1c9910ed4eb59767008e071c/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
[modify] https://crrev.com/57e5107fc7c70eaa1c9910ed4eb59767008e071c/chrome/browser/resources/settings/languages_page/languages_page.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/401867afab6dfa267f75d127bc047c6e62f6899c

commit 401867afab6dfa267f75d127bc047c6e62f6899c
Author: Marc-Antoine Courteau <macourteau@chromium.org>
Date: Fri Jun 08 16:25:04 2018

Fixes  crbug.com/814318  (spellcheck not functional):
- only disables the "spellcheck" section when spellchecking is disabled
  by policy, but not if disabled by the user;
- disables the context menu entry if spellcheck is enforced by policy.

This is a second attempt at landing this. The first attempt was reverted
due to the CrSettingsLanguagesPageTest.Spellcheck test failing.

Bug:  814318 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8f3da717f63ca00eedd82deff8fdbe6d60b10e34
Reviewed-on: https://chromium-review.googlesource.com/1091175
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565650}
[modify] https://crrev.com/401867afab6dfa267f75d127bc047c6e62f6899c/chrome/browser/renderer_context_menu/spelling_options_submenu_observer.cc
[modify] https://crrev.com/401867afab6dfa267f75d127bc047c6e62f6899c/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/401867afab6dfa267f75d127bc047c6e62f6899c/chrome/test/data/webui/settings/languages_page_tests.js