New issue
Advanced search Search tips

Issue 814309 link

Starred by 1 user
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jun 2018
Cc:
guidou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

getUserMedia({video: {facingMode: {exact: ''}}}) is accepted on desktop platforms

Project Member Reported by guidou@chromium.org, Feb 21 2018 
The empty string is not a valid facing mode, so this should be rejected on all platforms.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e058c9a6ce1d082a2cf040203494135c82248d6b

commit e058c9a6ce1d082a2cf040203494135c82248d6b
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Jun 04 10:07:00 2018

Do not allow the empty string as a facingMode constraint value for MediaStreams.

The empty string is an invalid facingMode value that was being
interpreted to be equivalent to the internal facing-mode value of NONE.

Bug:  814309 
Change-Id: I260fbc41fd17a8bdcd1ca63baffe3bed14f3c4ab
Reviewed-on: https://chromium-review.googlesource.com/1072471
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564046}
[modify] https://crrev.com/e058c9a6ce1d082a2cf040203494135c82248d6b/content/renderer/media/stream/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/e058c9a6ce1d082a2cf040203494135c82248d6b/content/renderer/media/stream/media_stream_constraints_util_video_device_unittest.cc
[add] https://crrev.com/e058c9a6ce1d082a2cf040203494135c82248d6b/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-invalid-facing-mode.https.html

Comment 2 by guidou@chromium.org, Jun 4 2018

Status: Fixed (was: Assigned)

Comment 3 by anatolid@chromium.org, Jun 7 2018 

[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
►

Sign in to add a comment