New issue
Advanced search Search tips

Issue 814305 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DEPS based HarfBuzz

Project Member Reported by drott@chromium.org, Feb 21 2018

Issue description

Move HarfBuzz dependency to DEPS based rolling.

Makes rolling easier and allows for easier bisecting on the Blink bots.

 

Comment 1 by drott@chromium.org, Feb 26 2018

Cherry-picking into refs/branch-heads does not seem to work (yet?), unless I did something wrong, compare: https://chromium-review.googlesource.com/c/chromium/src/+/937502

Hmmm... I guess we'll have to ask someone in infra if they have a solution. Either fetch refs/branch-heads all the time, mark the repo in DEPS as needing resf/branch-heads to be fetched, or fetch some other refs (like refs/chromium/** ) all the time (but which doesn't exist for most repos).
After taking a look, it appears only the branch builders pass --with_branch_heads . As a result, the normal builders don't even fetch tags, which is somewhat concerning.

In theory this would work if this were an actual branch being built by a branch builder. However, that's not much comfort to know that it 'should' work, when we really want to know and have tested that it is going to work when we need it in a pinch. As far as I know there are no trybots for branches, so there's no way to test anything.
The bot_update step itself takes a list of refs in a --refs param

https://cs.chromium.org/chromium/build/scripts/slave/bot_update.py?type=cs&q=gclient_sync+file:build/&sq=package:chromium&l=1402

but that appears to only apply to top level checkouts, except for "refs/branch-heads" which is detected and passed on to gclient as "with_branch_heads". "with_branch_heads" appears to apply to everything, but it appears it's not being fetched on the 'normal' builders to reduce the checkout.
Alright, we now have https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ which is mirroring harfbuzz refs/tags/* to refs/tags/* and refs/heads/* to refs/heads/upstream/* . Members of the harfbuzz-committers group should be able to push to any refs outside of refs/heads/upstream/* .

I'd recommend limiting ourselves to refs/heads/chromium/* (pushing to branches named something like chromium/m66 ), but I think we can push anywhere. Since all of these refs a branches (under refs/heads) they will get fetched by all the bots, so we won't have to do anything fancy.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ee2083397393ec92a26bfe93f21ad1cc17bfd59

commit 3ee2083397393ec92a26bfe93f21ad1cc17bfd59
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Mar 19 15:44:31 2018

Manage HarfBuzz dependency using DEPS mechanism

Remove src/ from Chromium repo and retrieve HarfBuzz sources from the
mirror at [1].

Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to
refs/heads/chromium/ of [1].

This was tested and confirmed working in::
https://chromium-review.googlesource.com/c/chromium/src/+/937502

[1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/

Bug:  814305 
Change-Id: I8760f734839012b1c9c9b9b07f11fa71000e5531
Reviewed-on: https://chromium-review.googlesource.com/928761
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544043}
[modify] https://crrev.com/3ee2083397393ec92a26bfe93f21ad1cc17bfd59/DEPS
[modify] https://crrev.com/3ee2083397393ec92a26bfe93f21ad1cc17bfd59/third_party/WebKit/LayoutTests/whitespace.txt
[modify] https://crrev.com/3ee2083397393ec92a26bfe93f21ad1cc17bfd59/third_party/harfbuzz-ng/BUILD.gn
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/COPYING
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/NEWS
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/README
[modify] https://crrev.com/3ee2083397393ec92a26bfe93f21ad1cc17bfd59/third_party/harfbuzz-ng/README.chromium
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-atomic-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-blob.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-blob.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-buffer-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-buffer-serialize.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-buffer.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-buffer.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-common.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-common.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-coretext.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-coretext.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-debug.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-deprecated.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-dsalgs.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-face-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-face.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-face.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-font-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-font.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-font.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ft.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ft.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-glib.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-glib.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-gobject-structs.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-gobject.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-graphite2.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-graphite2.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-icu.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-icu.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-mutex-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-object-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-font.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-kern-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-layout-jstf-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-map-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-map.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-math-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-math.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-math.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-name-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-post-macroman.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-post-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-fallback.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-win1256.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hangul.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer-machine.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-machine.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-table.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-fallback-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-normalize-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-shape.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-tag.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-tag.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-var-avar-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-var-fvar-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-var-hvar-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-var-mvar-table.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-var.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot-var.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ot.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-set-digest-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-set.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-set.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shape-plan-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shape-plan.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shape-plan.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shape.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shape.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shaper-impl-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shaper-list.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shaper-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-shaper.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-string-array.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-ucdn.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-unicode-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-unicode.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-unicode.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-utf-private.hh
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb-warning.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/hb.h
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/main.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/test-buffer-serialize.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/test-size-params.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/test-would-substitute.cc
[delete] https://crrev.com/610ee35516eef9064496111adbe4114fe0e4a226/third_party/harfbuzz-ng/src/test.cc

Comment 7 by drott@chromium.org, Mar 19 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bccaa54a86c7cd5f2e11be053e11c374af46046d

commit bccaa54a86c7cd5f2e11be053e11c374af46046d
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Mar 19 18:35:50 2018

Revert "Manage HarfBuzz dependency using DEPS mechanism"

This reverts commit 3ee2083397393ec92a26bfe93f21ad1cc17bfd59.

Reason for revert:  crbug.com/323342 . This only partially removed harfbuzz-ng/src, resulting in weird overlays of files from src.git and harbuzz.git

Original change's description:
> Manage HarfBuzz dependency using DEPS mechanism
> 
> Remove src/ from Chromium repo and retrieve HarfBuzz sources from the
> mirror at [1].
> 
> Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to
> refs/heads/chromium/ of [1].
> 
> This was tested and confirmed working in::
> https://chromium-review.googlesource.com/c/chromium/src/+/937502
> 
> [1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/
> 
> Bug:  814305 
> Change-Id: I8760f734839012b1c9c9b9b07f11fa71000e5531
> Reviewed-on: https://chromium-review.googlesource.com/928761
> Reviewed-by: Ben Wagner <bungeman@chromium.org>
> Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544043}

TBR=bungeman@chromium.org,eae@chromium.org,drott@chromium.org,behdad@chromium.org

Change-Id: I1fb32862c33154ac91d6475e8c1b6416fbc330ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  814305 
Reviewed-on: https://chromium-review.googlesource.com/969185
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544074}
[modify] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/DEPS
[modify] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/WebKit/LayoutTests/whitespace.txt
[modify] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/BUILD.gn
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/COPYING
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/NEWS
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/README
[modify] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/README.chromium
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-atomic-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-blob.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-blob.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-buffer-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-buffer-serialize.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-buffer.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-buffer.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-common.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-common.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-coretext.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-coretext.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-debug.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-deprecated.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-dsalgs.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-face-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-face.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-face.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-font-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-font.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-font.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ft.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ft.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-glib.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-glib.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-gobject-structs.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-gobject.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-graphite2.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-graphite2.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-icu.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-icu.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-mutex-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-object-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-font.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-kern-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-layout-jstf-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-map-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-map.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-math-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-math.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-math.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-name-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-post-macroman.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-post-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-fallback.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-win1256.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hangul.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer-machine.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-machine.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-table.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-fallback-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-normalize-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-shape.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-tag.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-tag.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-var-avar-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-var-fvar-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-var-hvar-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-var-mvar-table.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-var.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot-var.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ot.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-set-digest-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-set.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-set.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shape-plan-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shape-plan.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shape-plan.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shape.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shape.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shaper-impl-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shaper-list.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shaper-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-shaper.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-string-array.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-ucdn.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-unicode-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-unicode.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-unicode.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-utf-private.hh
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb-warning.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/hb.h
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/main.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/test-buffer-serialize.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/test-size-params.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/test-would-substitute.cc
[add] https://crrev.com/bccaa54a86c7cd5f2e11be053e11c374af46046d/third_party/harfbuzz-ng/src/test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60dab7e1fe51ebd7524fe5314ae765a701a288cd

commit 60dab7e1fe51ebd7524fe5314ae765a701a288cd
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Mar 20 09:55:47 2018

Manage HarfBuzz dependency using DEPS mechanism

Reland after revert in
https://chromium-review.googlesource.com/c/chromium/src/+/969185 as the
previous CL left files behind in the src directory and did not add the
src directory to .gitignore.

Remove src/ from Chromium repo and retrieve HarfBuzz sources from the
mirror at [1].

Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to
refs/heads/chromium/ of [1].

This was tested and confirmed working in::
https://chromium-review.googlesource.com/c/chromium/src/+/937502

[1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/

Bug:  814305 
Tbr: eae, behdad, bungeman
Change-Id: Ia4232a3231bb6388aaf31a0739626d778c5b6d68
Reviewed-on: https://chromium-review.googlesource.com/970242
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544320}
[modify] https://crrev.com/60dab7e1fe51ebd7524fe5314ae765a701a288cd/DEPS
[modify] https://crrev.com/60dab7e1fe51ebd7524fe5314ae765a701a288cd/third_party/.gitignore
[modify] https://crrev.com/60dab7e1fe51ebd7524fe5314ae765a701a288cd/third_party/WebKit/LayoutTests/whitespace.txt
[modify] https://crrev.com/60dab7e1fe51ebd7524fe5314ae765a701a288cd/third_party/harfbuzz-ng/BUILD.gn
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/COPYING
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/NEWS
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/README
[modify] https://crrev.com/60dab7e1fe51ebd7524fe5314ae765a701a288cd/third_party/harfbuzz-ng/README.chromium
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-atomic-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-blob.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-blob.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-buffer-deserialize-json.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-buffer-deserialize-text.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-buffer-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-buffer-serialize.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-buffer.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-buffer.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-common.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-common.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-coretext.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-coretext.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-debug.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-deprecated.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-dsalgs.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-face-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-face.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-face.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-font-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-font.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-font.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ft.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ft.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-glib.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-glib.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-gobject-structs.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-gobject-structs.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-gobject.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-graphite2.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-graphite2.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-icu.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-icu.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-mutex-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-object-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-open-file-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-open-type-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-cmap-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-color-cbdt-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-color-colr-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-color-cpal-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-font.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-font.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-glyf-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-hdmx-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-head-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-hmtx-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-kern-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-base-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-gdef-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-jstf-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-layout.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-map-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-map.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-math-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-math.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-math.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-maxp-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-name-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-os2-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-os2-unicode-ranges.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-post-macroman.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-post-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-fallback.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-win1256.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hangul.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer-machine.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-khmer.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-machine.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use-table.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-fallback-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-normalize-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-shape.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-tag.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-tag.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-var-avar-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-var-fvar-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-var-hvar-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-var-mvar-table.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-var.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot-var.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ot.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-set-digest-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-set-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-set.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-set.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shape-plan-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shape-plan.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shape-plan.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shape.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shape.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shaper-impl-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shaper-list.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shaper-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-shaper.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-string-array.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-subset-glyf.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-subset-plan.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-subset-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-subset.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-ucdn.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-unicode-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-unicode.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-unicode.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-utf-private.hh
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-version.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb-warning.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/hb.h
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/main.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/test-buffer-serialize.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/test-size-params.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/test-would-substitute.cc
[delete] https://crrev.com/b401d9b0f10151b25898737a1e5026fb5a112021/third_party/harfbuzz-ng/src/test.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c0344a12e552148c185f7d5117db1f28d6c9e85

commit 8c0344a12e552148c185f7d5117db1f28d6c9e85
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Tue Mar 20 12:39:06 2018

harfbuzz-ng: .gitignore the correct directory

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/970242

Bug:  814305 
Change-Id: I3e034eb8c1bc093cc6117641c625059f0e208f70
Reviewed-on: https://chromium-review.googlesource.com/970471
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544337}
[modify] https://crrev.com/8c0344a12e552148c185f7d5117db1f28d6c9e85/third_party/.gitignore

Sign in to add a comment