New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814274 link

Starred by 3 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jun 2018
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Toggle Button is seen Enabled automatically after clicking on 'ENTER' in 'ENTER SIM PIN' Dialog box in Cellular Connection Page

Project Member Reported by mmanchala@chromium.org, Feb 21 2018 
Chrome Version:  65.0.3325.89/10323.39.0  Beta-channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page
(3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> Click 'ENTER' 
(4)Now observe Toggle Button of 'Enable SIM Card locking(require PIN to use Mobile data) option is seen enabled   without closing 'ENTER SIM PIN' Dialog box (Please refer Video)

Expected: Toggle Button should be enabled only on closing 'ENTER SIM PIN' Dialog box
Actual: Instead Toggle Button of 'Enable SIM Card locking(require PIN to use Mobile data) option is seen enabled  after clicking on 'ENTER' in 'ENTER SIM PIN' Dialog box

This is Non-Regression issue seen from M-62

@stevenjb : Please confirm the issue

Note : 
1.Same is working fine in old settings page
2.Issue is seen on M-63, M-64 and on latest M-66 also
Actual_ToggleButtonBehavior.webm
505 KB View Download

Comment 1 by steve...@chromium.org, Feb 21 2018

Labels: -M-65 M-66

Comment 2 by steve...@chromium.org, Mar 2 2018

Labels: -M-66 M-67

Comment 3 by steve...@chromium.org, May 14 2018

Labels: -M-67 M-68

Comment 4 by steve...@chromium.org, Jun 7 2018

Status: Started (was: Assigned)
This only happens when entering an empty pin, which shouldn't be allowed anyway.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6202792062119091d345ff146f2125d709bd7de4

commit 6202792062119091d345ff146f2125d709bd7de4
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 12 22:33:35 2018

Settings > Network > SIM lock dialog: fix egde cases and cleanup

Bug:  814274 , 784804 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50c412d8ff26b5c78fb48834215d0d43277996a6
Reviewed-on: https://chromium-review.googlesource.com/1091804
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566609}
[modify] https://crrev.com/6202792062119091d345ff146f2125d709bd7de4/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/6202792062119091d345ff146f2125d709bd7de4/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Comment 6 by steve...@chromium.org, Jun 14 2018

Status: Fixed (was: Started)

Comment 7 by dsunk...@chromium.org, Sep 13

Owner: mmanchala@chromium.org
@mmanchala, can you please verify this bug?

Comment 8 by mmanchala@chromium.org, Oct 4

Owner: steve...@chromium.org
Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy

Thanks..!!
►

Sign in to add a comment