Issue metadata
Sign in to add a comment
|
47.8% improvement in smoothness.key_silk_cases at 536890:536935 |
||||||||||||||||||||
Issue descriptionSuspiciously large improvement, did something break?
,
Feb 21 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/118cea8f840000
,
Feb 21 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/118cea8f840000
,
Feb 21 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15f24a8f840000
,
Feb 22 2018
📍 Found significant differences after each of 4 commits. https://pinpoint-dot-chromeperf.appspot.com/job/15f24a8f840000 Revert "Enable root layer scrolling." by skobes@chromium.org https://chromium.googlesource.com/chromium/src/+/066296a5708f57ba89b68605ae8e65292eb77d4d [test_env.py] Warm up vpython virtualenv cache on swarming task shards. by iannucci@chromium.org https://chromium.googlesource.com/chromium/src/+/8348d507e280f4bd02a7737bf5577f838d64437e Revert "[test_env.py] Warm up vpython virtualenv cache on swarming task shards." by kbr@chromium.org https://chromium.googlesource.com/chromium/src/+/7dde857919af2f59fcab10264d696301a15c64da [RLS] Skip compositing input step if a scroll can be applied directly. by chrishtr@chromium.org https://chromium.googlesource.com/chromium/src/+/32419f4422bf130d9c52331a0c7dafba9337cc99 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 23 2018
,
Feb 25 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12807470440000
,
Feb 28 2018
Graphs seem to be recovering, but noisy.
,
Mar 10 2018
I think this regression has to do with InvalidatePaintUsingContainer somehow doing more work in the presence of RLS. Pre-RLS, SetBackingNeedsPaintInvalidationInRect would always follow the conditional at the bottom. Now, it's one of three conditionals in the middle, depending.
,
Mar 10 2018
,
Mar 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1768c76d47b9d2058f18dcf37e9a4097be43417c commit 1768c76d47b9d2058f18dcf37e9a4097be43417c Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Mar 10 03:00:55 2018 [PE] Optimize InvalidatePaintUsingContainer. If a paint invalidation container returns true from IsPaintInvalidationContainer(), that means it is composited, which in turn must mean the containing LayoutView is composited. This allows us to simplify the code and avoid a call to View(), which may be expensive because it has to first dereference the document. Bug: 814251 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I79cc37ee79271c2030a9f5c832ba5640ca8445c9 Reviewed-on: https://chromium-review.googlesource.com/957962 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542333} [modify] https://crrev.com/1768c76d47b9d2058f18dcf37e9a4097be43417c/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
,
Mar 10 2018
This was a progression in the first place, I had read the graphs backwards. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 21 2018