Issue metadata
Sign in to add a comment
|
4.8%-72.9% regression in smoothness.tough_canvas_cases at 537365:537487 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 21 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11f1bef7840000
,
Feb 22 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11f1bef7840000 cc: Serialize bitmap backed images for OOP raster. by khushalsagar@chromium.org https://chromium.googlesource.com/chromium/src/+/73760a33887fc8333fe071dd0e5e8c17891e9518 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 22 2018
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cace4d4608929f1febdba2a1535c111945afe1fd commit cace4d4608929f1febdba2a1535c111945afe1fd Author: Khushal <khushalsagar@chromium.org> Date: Mon Feb 26 22:06:25 2018 canvas: Ensure stable content ids for canvas image snapshots. When taking a snapshot from an SkSurface, it internally maintains a cached copy of the SkImage which is invalidated only when the canvas contents change. This ensures re-using cached texture uploads from this image on subsequent uses. However, when building a PaintImage using this SkImage we generate a new content id for each draw, resulting in a cache miss on cc's decode cache and re-upload with color conversion. Ensure that we use a stable PaintImage::ContentId for the same SkImage. R=junov@chromium.org Bug: 814226 , 814219 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie1d8ebb40ccf98593dac3e6f65ca705054e6d90b Reviewed-on: https://chromium-review.googlesource.com/932942 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#539280} [modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/cc/paint/paint_image.cc [modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/cc/paint/paint_image.h [modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.cpp [modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.h
,
Feb 27 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 21 2018