New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814226 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.8%-72.9% regression in smoothness.tough_canvas_cases at 537365:537487

Project Member Reported by alexclarke@chromium.org, Feb 21 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 21 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=814226

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8b8066d6fa04961662847d11a9248c0790bcdef009293e48cf82602ae27f4c08


Bot(s) for this bug's original alert(s):

android-nexus6
android-one
android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 22 2018

Cc: chrishtr@chromium.org asvitk...@chromium.org dalecur...@chromium.org khushals...@chromium.org enne@chromium.org piman@chromium.org
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11f1bef7840000

cc: Serialize bitmap backed images for OOP raster. by khushalsagar@chromium.org
https://chromium.googlesource.com/chromium/src/+/73760a33887fc8333fe071dd0e5e8c17891e9518

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: briander...@chromium.org
 Issue 814047  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cace4d4608929f1febdba2a1535c111945afe1fd

commit cace4d4608929f1febdba2a1535c111945afe1fd
Author: Khushal <khushalsagar@chromium.org>
Date: Mon Feb 26 22:06:25 2018

canvas: Ensure stable content ids for canvas image snapshots.

When taking a snapshot from an SkSurface, it internally maintains a
cached copy of the SkImage which is invalidated only when the canvas
contents change. This ensures re-using cached texture uploads from this
image on subsequent uses.

However, when building a PaintImage using this SkImage we generate a
new content id for each draw, resulting in a cache miss on cc's decode
cache and re-upload with color conversion. Ensure that we use a stable
PaintImage::ContentId for the same SkImage.

R=junov@chromium.org

Bug:  814226 ,  814219 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie1d8ebb40ccf98593dac3e6f65ca705054e6d90b
Reviewed-on: https://chromium-review.googlesource.com/932942
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539280}
[modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/cc/paint/paint_image.cc
[modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/cc/paint/paint_image.h
[modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.cpp
[modify] https://crrev.com/cace4d4608929f1febdba2a1535c111945afe1fd/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.h

Status: Fixed (was: Assigned)

Sign in to add a comment