Issue metadata
Sign in to add a comment
|
11.7%-68.6% regression in thread_times.tough_compositor_cases at 537300:537429 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 21 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16b25327840000
,
Mar 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ba1422440000
,
Mar 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14c4e692440000
,
Mar 6 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/14c4e692440000 Renderer observer of frame submission by jonross@chromium.org https://chromium.googlesource.com/chromium/src/+/a2ff4f82109df55045dee9f54985a98054f86dc4 Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org https://chromium.googlesource.com/chromium/src/+/cf91f7965c29e2bc93e81f79cef5d77481b00e6e Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 6 2018
,
Mar 13 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/166e6e06440000
,
Mar 13 2018
,
Mar 13 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14cb244e440000
,
Mar 13 2018
Looking at the graphs, it's clear the regression occurred after root-layer-scrolling was turned on. RLS did regress the graphs but this shows up as a regression earlier than the one linked with this bug. Those regressions are fixed (in this range: https://chromium.googlesource.com/chromium/src/+log/1c7a6ab994d205d84cab9cd153b16b0edec9efaf%5E..52c5105d39b7d838daabddf79f0aa4d225bfec27?pretty=fuller&n=1000 - several fixes from szager@ and chrishtr@) just before whatever caused this regression. I'll try to get a bisect to point out a culprit since this seems like a pretty bad regression but I don't think we should block RLS on it.
,
Mar 13 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16cd6b8e440000
,
Mar 14 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/14cb244e440000 Renderer observer of frame submission by jonross@chromium.org https://chromium.googlesource.com/chromium/src/+/a2ff4f82109df55045dee9f54985a98054f86dc4 Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org https://chromium.googlesource.com/chromium/src/+/cf91f7965c29e2bc93e81f79cef5d77481b00e6e Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 14 2018
There's two regressions in a small range. Some of the graphs only show one large regression because both patches fall into the same build. The regressions can be seen separately rather clearly in android-nexus5/thread_times.tough_compositor_cases / tasks_per_frame_browser: https://chromeperf.appspot.com/report?sid=17a475c5683524e935691ef96197befa1d8908eca1c6154bfd1dcef0d912fcf9&start_rev=534657&end_rev=539290 This alert is actually on jonross@'s CL so assigning to him to take a look. I'll file a separate bug for szager@'s regression.
,
Mar 14 2018
I added rate limiting to my change identified in #12 in 540539. When you expand the graphs range you can see drop downs after that patch. Since szager@'s patch is being tracked separately I'm closing this one out.
,
Mar 15 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/16cd6b8e440000 Renderer observer of frame submission by jonross@chromium.org https://chromium.googlesource.com/chromium/src/+/a2ff4f82109df55045dee9f54985a98054f86dc4 Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org https://chromium.googlesource.com/chromium/src/+/cf91f7965c29e2bc93e81f79cef5d77481b00e6e Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 15 2018
Ah, thanks Jon. Interestingly in the grouped graphs link above "tasks_per_frame_browser" didn't show the most recent runs. That graph has indeed recovered.
,
Mar 15 2018
For completeness, the split out bug is issue 821953 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 21 2018