New issue
Advanced search Search tips

Issue 814214 link

Starred by 1 user
Status: Fixed
Owner:
hta@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create DTMFSender without an attached track

Project Member Reported by hta@chromium.org, Feb 21 2018 
At the moment, creating an RTCDTMFSender requires a track.
The specification doesn't say anything about needing a track to be attached.

This needs:
- RTCRtpSenders to know if they are audio senders or not
- The API for creating DTMF senders to be in terms of senders not tracks

As part of this, the legacy CreateDTMFSender needs to be rewritten in terms of returning the relevant "dtmf" attribute for the track's sender, rather than the "dtmf" attribute being created by calling CreateDTMFSender.

Comment 1 by hta@chromium.org, Feb 21 2018

Owner: hta@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9

commit c82da000ab66e7291ef79c2ab0afc954b0bcb5f9
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Feb 28 09:39:34 2018

Change RTCRtpSender.dtmf to call sender directly

This makes the "dtmf" attribute of RTCRtpSender link
directly to the sender-based DTMF sender in the WebRTC
layer, without going through the track.

Bug:  814214 
Change-Id: I5b04a64a7e9105ef4a8ed5e826eb812ea43ea8ac
Reviewed-on: https://chromium-review.googlesource.com/936765
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539769}
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/peer_connection_tracker.cc
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/peer_connection_tracker.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/rtc_peer_connection_handler.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/rtc_rtp_sender.cc
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/content/renderer/media/webrtc/rtc_rtp_sender.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-createDTMFSender.html
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/modules/peerconnection/RTCRtpSender.cpp
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/modules/peerconnection/RTCRtpSender.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.cpp
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h
[modify] https://crrev.com/c82da000ab66e7291ef79c2ab0afc954b0bcb5f9/third_party/WebKit/public/platform/WebRTCRtpSender.h

Comment 3 by hta@chromium.org, Feb 28 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment