New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814155 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.8% regression in jetstream at 536173:536250

Project Member Reported by alexclarke@chromium.org, Feb 21 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 21 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=814155

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=bd3192b585180c9fd46e363690d6cd60c9a69f230243b6a4d1b03b5c046837ec


Bot(s) for this bug's original alert(s):

chromium-rel-mac12
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 23 2018

Cc: gov...@chromium.org iannucci@chromium.org tandrii@chromium.org
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12d88987840000

Updating XTBs based on .GRDs from branch master by govind@chromium.org
https://chromium.googlesource.com/chromium/src/+/056d08eee04db3f48c53adb416c7044993ebceab

CQ: stop processing CLs. by tandrii@chromium.org
https://chromium.googlesource.com/chromium/src/+/6c234973451d66de1b7c46aca115671a883f521e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -iannucci@chromium.org -tandrii@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
the file in touched is cq.cfg, it affects only commit queue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Feb 26 2018

Cc: iannucci@chromium.org tandrii@chromium.org
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14c98a48440000

CQ: stop processing CLs. by tandrii@chromium.org
https://chromium.googlesource.com/chromium/src/+/6c234973451d66de1b7c46aca115671a883f521e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: ----
Status: Untriaged (was: Assigned)
argh, apparently bisect is very insisting. Can it be that something in chromium compiles based on cq.cfg contents?!
Cc: sullivan@chromium.org
Owner: hablich@chromium.org
Status: Assigned (was: Untriaged)
Assigning to hablich, owner of the jetstream benchmark. hablich, it looks like the benchmark is too sensitive on Mac 10.12--the bisect run on the build with tandrii's CQ change consistently gives a different value than the previous build, even though it shouldn't affect compile at all. This means that bisect can't work correctly. Any ideas what to do about the noise level of the test?
Cc: hablich@chromium.org
Owner: tandrii@chromium.org
Interesting. What do you mean the benchmark is to sensitive? The score changes by ~ 10 %, that is significant. Maybe the CQ config change removes a work that would run while the bot executes the benchmark? https://chromiumdash.appspot.com/commit/6c234973451d66de1b7c46aca115671a883f521e paints a quite interesting picture. Lots of improvements in the CL range.

Are the bots using cq.cfg?
Owner: hablich@chromium.org
hablich: None of the pinpoint bots are using cq.cfg, and the file isn't compiled into chromium, so there should be no way that this change can affect chrome's performance. We prebuild binaries at each revision, so it looks like compile churn is causing a significant difference between the two binaries on this test. This is why I think the benchmark is too sensitive, it's producing a false positive between these two versions which shouldn't have any different code. 
Owner: mvstan...@chromium.org
Surprising indeed.

mvstanton, any clue what's going on with Jetstream?
Cc: -tandrii@chromium.org
Status: WontFix (was: Assigned)
A few weeks before we checked in side-channel mitigations that affected JetStream (crbug.com/812205), that could be showing up here too.

Sign in to add a comment