New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814144 link

Starred by 1 user
Status: Fixed
Owner:
█ hpayer@chromium.org
Last visit > 30 days ago
Closed: Jul 5
Cc:
█ hpayer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

V8 GC metrics need to be suffixed with .Foreground/.Background

Project Member Reported by gab@chromium.org, Feb 21 2018 
Not having a notion of whether a GC timing comes from GC for foreground (visible or hearable) or background content makes it such that we can't go after improving the 99th'ile (as it's polluted with use cases which the scheduler intentionally make slow when the content isn't visible -- e.g. backgrounding the entire process' priority).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e32c5946d29b9663b1f73d4567ea2d2ea8f66894

commit e32c5946d29b9663b1f73d4567ea2d2ea8f66894
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Apr 05 21:08:03 2018

[heap] Add foreground/background UMA measurements for for main GC events.

Bug:  chromium:814144 
Change-Id: Idd729757608a714921254874af98a4a201340870
Reviewed-on: https://chromium-review.googlesource.com/981146
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52414}
[modify] https://crrev.com/e32c5946d29b9663b1f73d4567ea2d2ea8f66894/src/counters.h
[modify] https://crrev.com/e32c5946d29b9663b1f73d4567ea2d2ea8f66894/src/heap/heap.cc
[modify] https://crrev.com/e32c5946d29b9663b1f73d4567ea2d2ea8f66894/src/heap/heap.h

Comment 2 by gab@chromium.org, Apr 5 2018 

Awesome :)! Excited to hear what you find there and how it allows you to push further! (hopefully there's already a big difference between the two at the 99th'ile, especially on Windows where we have true background processes, and we can spread it further now that we have separate metrics)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa62dadac30abff397d6c276305316f5aa281393

commit fa62dadac30abff397d6c276305316f5aa281393
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Apr 12 16:10:12 2018

Enable various V8 garbage collection timing foreground and background metrics on UMA.

The V8-side landed in: https://chromium-review.googlesource.com/c/v8/v8/+/981146

Bug:  chromium:814144 
Change-Id: I3ef9523b4a0f371ce0f22400ef3c70bb521117ee
Reviewed-on: https://chromium-review.googlesource.com/999472
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550225}
[modify] https://crrev.com/fa62dadac30abff397d6c276305316f5aa281393/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa62dadac30abff397d6c276305316f5aa281393

commit fa62dadac30abff397d6c276305316f5aa281393
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Apr 12 16:10:12 2018

Enable various V8 garbage collection timing foreground and background metrics on UMA.

The V8-side landed in: https://chromium-review.googlesource.com/c/v8/v8/+/981146

Bug:  chromium:814144 
Change-Id: I3ef9523b4a0f371ce0f22400ef3c70bb521117ee
Reviewed-on: https://chromium-review.googlesource.com/999472
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550225}
[modify] https://crrev.com/fa62dadac30abff397d6c276305316f5aa281393/tools/metrics/histograms/histograms.xml

Comment 5 by hpayer@chromium.org, Jul 5

Status: Fixed (was: Assigned)
►

Sign in to add a comment