New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814140 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove IDR_STORAGE_MANAGER_BUTTON

Project Member Reported by tetsui@chromium.org, Feb 21 2018

Issue description

IDR_STORAGE_MANAGER_BUTTON is used as a button icon in arc_boot_error_notification.cc, but NotificationViewMD no longer uses ButtonInfo.icon so we can remove this entirely.

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc?l=52&rcl=e24c90e284ccaae925132cc0271d9179b5560ec3
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c458698ef6178d0b8e480753636ff695b12e20bc

commit c458698ef6178d0b8e480753636ff695b12e20bc
Author: Megumi Hattori <megumihattori@google.com>
Date: Fri Feb 23 03:32:09 2018

Remove unused IDR_STORAGE_MANAGER_BUTTON

NotificationViewMD no longer uses ButtonInfo.icon, so
IDR_STORAGE_MANAGER_BUTTON which is used for a button image of the low
disk space error notification can be removed.

This CL does not change the UI at all.

BUG= 814140 
TEST=manual

Change-Id: Ib87a44d95805110ad6f70b490eb559a9d8a2fb73
Reviewed-on: https://chromium-review.googlesource.com/928187
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538687}
[modify] https://crrev.com/c458698ef6178d0b8e480753636ff695b12e20bc/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc
[delete] https://crrev.com/fa5503b828721a5e007df7d1d8abdd81f8115b58/ui/chromeos/resources/default_100_percent/filesystem/button_storage_manager.png
[delete] https://crrev.com/fa5503b828721a5e007df7d1d8abdd81f8115b58/ui/chromeos/resources/default_200_percent/filesystem/button_storage_manager.png
[modify] https://crrev.com/c458698ef6178d0b8e480753636ff695b12e20bc/ui/chromeos/resources/ui_chromeos_resources.grd

Status: Fixed (was: Started)

Sign in to add a comment