New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Heap parameters should be size_t

Project Member Reported by mlippautz@chromium.org, Feb 21 2018

Issue description

Proxy bug for https://github.com/nodejs/node/issues/18786

Main issue is increasing size of the old generation on 64-bit architectures.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/46c4979e860a9aaf4444616955e896e70e72afbf

commit 46c4979e860a9aaf4444616955e896e70e72afbf
Author: Ben Noordhuis <info@bnoordhuis.nl>
Date: Wed Feb 21 15:04:12 2018

Use wider types for max_old_space_size and co.

Make --max_old_space_size and friends work with values >= 2**31.
Such values did not work reliably (or sometimes not all) due to
signed integer overflow in size computations, which is UB.

Fixes https://github.com/nodejs/node/issues/18786.

Bug:  chromium:814138 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ibe23cef2417fd5b4a727022b8b0d4b50f1417182
Reviewed-on: https://chromium-review.googlesource.com/927063
Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51433}
[modify] https://crrev.com/46c4979e860a9aaf4444616955e896e70e72afbf/include/v8.h
[modify] https://crrev.com/46c4979e860a9aaf4444616955e896e70e72afbf/src/api.cc
[modify] https://crrev.com/46c4979e860a9aaf4444616955e896e70e72afbf/src/flag-definitions.h
[modify] https://crrev.com/46c4979e860a9aaf4444616955e896e70e72afbf/src/flags.cc
[modify] https://crrev.com/46c4979e860a9aaf4444616955e896e70e72afbf/src/heap/heap.cc
[modify] https://crrev.com/46c4979e860a9aaf4444616955e896e70e72afbf/src/heap/heap.h

Status: Fixed (was: Available)

Sign in to add a comment