New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814130 link

Starred by 3 users
Status: Fixed
Owner:
rouslan@chromium.org
Closed: Feb 2018
Cc:
█ zkoch@chromium.org
mahmadi@chromium.org
gogerald@chromium.org
msramek@chromium.org
anthonyvd@chromium.org
█ durgapandey@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Credit card and billing info saved after closing incognito tabs

Reported by matthew....@gmail.com, Feb 21 2018 
Chrome Version       : 64.0.3282.167
OS Version: OS X 10.13.3
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox:
    IE/Edge:

What steps will reproduce the problem?
1. In incognito tab: Go to checkout on a site that uses Payment Request API
2. Add a card and/or billing address
3. Close all incognito tabs
4. In regular tab: Go to checkout on a site that uses Payment Request API
5. Notice that the payment info was saved, since it appears in the autofill

What is the expected result?
Payment info from incognito should not be saved

What happens instead of that?
The credit card and billing address appear

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36
Screen Shot 2018-02-20 at 11.31.42 PM.png
281 KB View Download
Screen Shot 2018-02-20 at 11.33.17 PM.png
327 KB View Download

Comment 1 by mkwst@chromium.org, Feb 21 2018

Cc: msramek@chromium.org durgapandey@chromium.org zkoch@chromium.org
Components: UI>Browser>Incognito UI>Browser>Payments Privacy
Labels: -Pri-3 ReleaseBlock-Stable M-66 Pri-1
Owner: rouslan@chromium.org
Status: Assigned (was: Unconfirmed)
rouslan@, durgapandey@: Can you triage this to someone in the payments team? I don't believe we should be storing this information to our backend for folks using Incognito.

Marking this as blocking stable for 66. It's likely too late for M-65, but if we could merge it there as well, I'd be happier. :)

Comment 2 by rouslan@chromium.org, Feb 21 2018

Cc: gogerald@chromium.org anthonyvd@chromium.org mahmadi@chromium.org
Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Windows
Ganggui: Could you fix this on Android, please?

Anthony: Could you fix this on desktop, please?

Moe: Could you fix this on iOS, please?
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d131a4032e033e02f2a78efb69dd863efe5a21

commit 10d131a4032e033e02f2a78efb69dd863efe5a21
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Feb 22 15:41:04 2018

[Web Payments] Don't save data from Payment Request in Incognito

Bug:  814130 
Change-Id: I331aea2babdf1ba01c488e7ead98db738e0242f4
Reviewed-on: https://chromium-review.googlesource.com/929584
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538441}
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/contact_info_editor_view_controller.h
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/components/payments/content/payment_request.cc
[modify] https://crrev.com/10d131a4032e033e02f2a78efb69dd863efe5a21/components/payments/content/payment_request.h
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdcd36c427d790903523bf7058422ea808a21f0c

commit bdcd36c427d790903523bf7058422ea808a21f0c
Author: gogerald <gogerald@google.com>
Date: Thu Feb 22 17:03:36 2018

[Payments] Do not save cards and profiles in incognito mode

Bug:  814130 
Change-Id: I3b8ff51af5bf02f24033a2e11fb9df948773fd98
Reviewed-on: https://chromium-review.googlesource.com/929744
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538460}
[modify] https://crrev.com/bdcd36c427d790903523bf7058422ea808a21f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/bdcd36c427d790903523bf7058422ea808a21f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/bdcd36c427d790903523bf7058422ea808a21f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/bdcd36c427d790903523bf7058422ea808a21f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/bdcd36c427d790903523bf7058422ea808a21f0c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditorPreference.java
[modify] https://crrev.com/bdcd36c427d790903523bf7058422ea808a21f0c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsSectionUnitTest.java
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/794427c30ec1653b2bd9e8e8313934639b7699ed

commit 794427c30ec1653b2bd9e8e8313934639b7699ed
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Sun Feb 25 19:27:16 2018

[PR] Don't save Payment Request data in PersonalDataManager in Incognito

Fixes the bug where changes to existing autofill profiles and credit cards
or adding new ones get reflected in PersonalDataManager when user is in
incognito mode.
Also refactors the details of adding/updating autofill profiles and credit
cards into the paymentrequest.mm instead of the coordinators.
Updates the unit tests accordingly.

Bug:  814130 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2cc72032648d162304211fe3de6612bc23848350
Reviewed-on: https://chromium-review.googlesource.com/931625
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539048}
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/payments/BUILD.gn
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/payments/payment_request.h
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/payments/test_payment_request.h
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/payments/test_payment_request.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/ui/payments/address_edit_coordinator.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/ui/payments/contact_info_edit_coordinator.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/ui/payments/credit_card_edit_coordinator.mm
[modify] https://crrev.com/794427c30ec1653b2bd9e8e8313934639b7699ed/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm

Comment 6 by rouslan@chromium.org, Feb 26 2018

Owner: mahmadi@chromium.org
Moe: Can you please verify whether this is an issue on iOS and close if not?

Comment 7 by rouslan@chromium.org, Feb 26 2018

Owner: rouslan@chromium.org
Status: Fixed (was: Assigned)
Doh! It's fixed.
►

Sign in to add a comment