New issue
Advanced search Search tips

Issue 814128 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

remove command line switches crash keys limitation

Reported by rkuk...@yandex-team.ru, Feb 21 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 YaBrowser/18.3.1.372 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
See components/crash/core/common/crash_keys.cc 

What is the expected behavior?

What went wrong?
There are more than 15 command line switches in some of chromium processes. Some switches are larger than 64B.

Did this work before? No 

Chrome version: 64.0.3282.140  Channel: n/a
OS Version: 10.0
Flash Version: doesn't matter

We can remove the limitation as new Annotations API is ready.
 
Labels: Needs-Triage-M64
Components: Internals
Labels: Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to .cc files. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0dca06a97a8930978e6f15944886dd8f93cab94

commit d0dca06a97a8930978e6f15944886dd8f93cab94
Author: Roman Kuksin <rkuksin@yandex-team.ru>
Date: Mon Feb 26 20:33:49 2018

Remove size limitation for switch-* crash keys.

Bug:  814128 
Change-Id: Ib4585da0192392d4de6f3308369a23f686b1d611
Reviewed-on: https://chromium-review.googlesource.com/926127
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539256}
[modify] https://crrev.com/d0dca06a97a8930978e6f15944886dd8f93cab94/components/crash/core/common/crash_keys.cc
[modify] https://crrev.com/d0dca06a97a8930978e6f15944886dd8f93cab94/components/crash/core/common/crash_keys_unittest.cc

Comment 5 by rsesek@chromium.org, Feb 26 2018

Components: -Internals Internals>CrashReporting
Labels: OS-Android OS-Chrome OS-Linux OS-Mac

Comment 6 by lgrey@chromium.org, Feb 28 2018

[mac triage] Is this fixed?

Comment 7 by rsesek@chromium.org, Feb 28 2018

Status: Fixed (was: Unconfirmed)

Sign in to add a comment