New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814115 link

Starred by 2 users
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Feb 2018
Cc:
█ mgiuca@chromium.org
hwi@chromium.org
srahim@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[desktop-pwas] App Info in launcher should open Site settings

Project Member Reported by mgiuca@chromium.org, Feb 21 2018 
Chrome Version: 66
OS: Chrome

What steps will reproduce the problem?
(1) Turn on flag #enable-desktop-pwas
(2) Install a PWA, e.g., Santa Tracker.
(3) Open Launcher.
(4) Right-click Santa Tracker -> App Info

What is the expected result?
Opens Site settings page for Santa Tracker in a browser tab.

What happens instead?
Opens App Info dialog for Santa Tracker. This isn't useful as it contains no "true" information.

See  bug 811178  for equivalent behaviour in 3-dot menu (from within the app).

Comment 1 by mgiuca@chromium.org, Feb 21 2018

Cc: srahim@chromium.org
Labels: -Pri-3 Pri-1
+srahim: Can we pick a different string other than "App Info" here?

In the 3-dot menu (from within the app window), "App Info" opens the page info dialog.

In the Launcher context menu, "App Info" opens the Site settings page.

They should have different strings. The reason we use "App Info" is for consistency with the other types of apps. But maybe we should just say "Site settings" for the launcher version?

Comment 2 by alancutter@chromium.org, Feb 21 2018 

App Info in the launcher already opens Site Settings.

Comment 3 by alancutter@chromium.org, Feb 21 2018 

This behaviour was added in 61c1f7910f2733ef0f60736f885a60edf62f7052.

Comment 4 by alancutter@chromium.org, Feb 21 2018 

For context there's existing discussion over the name App Info/Site Settings.
https://docs.google.com/a/google.com/presentation/d/1HDXjNMQVuubUdLnS4uF8xdwki4Lo7gSJSZi-VSq2LZ8/edit?disco=AAAABploJlE

Comment 5 by srahim@chromium.org, Feb 22 2018 

Hwi & I discussed, and there honestly isn't a good replacement given the different contexts and the text currently used in Page Info and on the Site Settings page. 

In the short term, we recommend keeping "App info" as is. 

Longer term: 1) we'd like to evaluate the language used in Site Settings for the PWA case. 2) we'd like to also evaluate what we show when the user clicks App Info from the Launcher - ideally we'd include information about the PWA other than permissions, like non-PWA apps do in their app info.

Comment 6 by alancutter@chromium.org, Feb 23 2018

Status: Fixed (was: Assigned)
Making Site Settings more compatible with the App Info intention in the future SGTM.
►

Sign in to add a comment