Issue metadata
Sign in to add a comment
|
Desktop PWAs: three dot menu > App Info should include site origin with security icon |
||||||||||||||||||||||||
Issue description
,
Feb 21 2018
Wait, what are all those ticks? (Are they just demonstrations of your ability to add icons?)
,
Feb 21 2018
They are example minor icons.
,
Feb 22 2018
+hwi: Do we need to elide origins here or is it fine to let the app menu be arbitrarily wide? See screenshots for currently implemented behaviour.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfacd4cfe6d1240f8b2567d94157958113d6eea8 commit bfacd4cfe6d1240f8b2567d94157958113d6eea8 Author: Alan Cutter <alancutter@chromium.org> Date: Fri Feb 23 00:07:59 2018 Use assignment for building SimpleMenuModel::Items This CL is a pure refactor with no changes in behaviour. This is in preparation for adding a new field to Item without having to update unrelated construction sites and avoids repetition of default values. Bug: 814109 Change-Id: I9bd97eb2e1fde101cf0b70789556a1d097e89dfc Reviewed-on: https://chromium-review.googlesource.com/923601 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#538627} [modify] https://crrev.com/bfacd4cfe6d1240f8b2567d94157958113d6eea8/ui/base/models/simple_menu_model.cc [modify] https://crrev.com/bfacd4cfe6d1240f8b2567d94157958113d6eea8/ui/base/models/simple_menu_model.h
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55dc8afede01bbcf84d022a2503cd5d0f7e51b80 commit 55dc8afede01bbcf84d022a2503cd5d0f7e51b80 Author: Alan Cutter <alancutter@chromium.org> Date: Fri Feb 23 06:55:30 2018 Add minor icon to Views menus This CL introduces no changes in behaviour.* This adds a new feature to views menus for showing an icon next to a menu item's minor text. This feature is in preparation for showing a security lock icon in a hosted app's three dot menu on chromeOS. Screenshots with example tick minor icons added to every menu item: LTR: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325929&signed_aid=ojjZXii5eRC_lCJRcE2cEw==&inline=1 RTL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325930&signed_aid=mx16iMowovDNfJSIuk3d1w==&inline=1 * The text rendering of minor text has changed from Canvas to RenderText and drops underlining of accelerator characters. This is okay because accelerators aren't ever specified in minor text. Bug: 814109 Change-Id: Ide209649b7f45a0269a922c7683d0a8c76310009 Reviewed-on: https://chromium-review.googlesource.com/927965 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#538715} [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/chrome/browser/ui/views/menu_item_view_interactive_uitest.cc [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/base/models/menu_model.cc [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/base/models/menu_model.h [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/base/models/simple_menu_model.cc [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/base/models/simple_menu_model.h [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/views/controls/menu/menu_item_view.h [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/views/controls/menu/menu_item_view_unittest.cc [modify] https://crrev.com/55dc8afede01bbcf84d022a2503cd5d0f7e51b80/ui/views/controls/menu/menu_model_adapter.cc
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6210fbb60b61360409eb9f9808f39c0f2d8629e commit c6210fbb60b61360409eb9f9808f39c0f2d8629e Author: Alan Cutter <alancutter@chromium.org> Date: Fri Feb 23 07:55:20 2018 Show origin and security icon inside App Info menu item This CL adds the origin string and security level icon indicator inside the hosted app's three dot menu. Screenshots: Lock icon: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325757&signed_aid=y0yCNag6ofiB9TGamFqxVw==&inline=1 Info icon: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325758&signed_aid=BpISC2MNMuvLyPJfJhaIkw==&inline=1 Warning icon: https://bugs.chromium.org/p/chromium/issues/attachment?aid=325763&signed_aid=e5D-egGM3PjGsn9ASERWkg==&inline=1 Bug: 814109 Change-Id: I98425b340a12d90dcf05b11a484229fedf7475a9 Reviewed-on: https://chromium-review.googlesource.com/928322 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#538725} [modify] https://crrev.com/c6210fbb60b61360409eb9f9808f39c0f2d8629e/chrome/browser/ui/extensions/hosted_app_menu_model.cc
,
Feb 24 2018
c10: *no-eliding* seems to make more sense within the menu
,
Mar 8 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by alancutter@chromium.org
, Feb 21 201817.1 KB
17.1 KB View Download
22.4 KB
22.4 KB View Download