New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814106 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX

Blocking:
issue 882382



Sign in to add a comment

Chrome requires access to Location to disable Location prompts

Project Member Reported by benwells@chromium.org, Feb 21 2018

Issue description

From a feedback report:

Settings > Site Settings > Location entry cannot be changed unless I give chrome location access. I want to stop location permission popups when visiting websites.
 
Cc: finnur@chromium.org raymes@chromium.org
Components: UI>Browser>SiteSettings
Labels: -Pri-3 FoundIn-66 Pri-2
Summary: Chrome requires access to Location to disable Location prompts (was: Need to give chrome access to disable location prompts)
Indeed, if you deny Location access to Android Chrome, you cannot then disable the Location setting in Chrome Settings, leading to annoying permission prompts.

I think the problematic code is around https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java?l=705&rcl=9ee27abfd52a6fc4951be5010f1ed884823d7c12


Status: Available (was: Untriaged)

Comment 3 by cthomp@chromium.org, Mar 20 2018

Components: -Internals>Permissions Internals>Permissions>Model

Comment 4 by jochen@chromium.org, May 14 2018

Components: Privacy
Blocking: 882382
Owner: hkamila@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ea0e6e86497b8e28e2b744f534128cf5f001308

commit 5ea0e6e86497b8e28e2b744f534128cf5f001308
Author: Kamila <hkamila@google.com>
Date: Mon Nov 19 15:25:43 2018

Allow the user to disable permission prompts when disabled in Android (behind flag)

1. Enables modification of the toggle of Chrome Site Settings permissions which can be managed
in Android. This is done in order for the user to be able to disable these permissions in
settings, even when access is not granted to Chrome in Android.

The permissions modified are:
- Camera
- Location
- Microphone
- Notifications

2. Changes the string and makes it appear only when the permission is disabled for Chrome, but
the user hasn't disabled the permission in Chrome. (as per comments in patchset 5)

---------
Images
---------
Before
In any case when location is blocked for Chrome in Android:
https://imgur.com/a/6r2MMan

After
Location Blocked for Chrome and in Chrome: https://imgur.com/a/wsXfrzL
Location Blocked for Chrome but "Ask" in Chrome: https://imgur.com/a/qiq3XTP

---------
Note
---------
This cl was initially intended just to change the UI for Location permission, but the change
makes sense for all permissions similar to Location. The initial image with only the location
change until patchset 5 was: https://imgur.com/a/WjHqUZu


Bug: 814106
Change-Id: Iefd929cf85f83a6f1dd3155c75875c2d3f66829d
Reviewed-on: https://chromium-review.googlesource.com/c/1275853
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609301}
[modify] https://crrev.com/5ea0e6e86497b8e28e2b744f534128cf5f001308/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/5ea0e6e86497b8e28e2b744f534128cf5f001308/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
[modify] https://crrev.com/5ea0e6e86497b8e28e2b744f534128cf5f001308/chrome/android/java/strings/android_chrome_strings.grd

Sign in to add a comment