New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814099 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 765859
issue 814087

Blocking:
issue 815183



Sign in to add a comment

Bot "chromium.clang:UBSanVptr Linux" possibly misconfigured

Project Member Reported by kbr@chromium.org, Feb 21 2018

Issue description

Not sure which component to put this in; there doesn't seem to be one for either Clang or ASAN/TSAN/MSAN.

In writing a test verifying all of the trybots' configurations in Issue 814087, it was discovered that the following trybot was mirroring a nonexistent waterfall bot:

linux_chromium_ubsan_rel_ng on tryserver.chromium.linux: UBSanVptr Linux on chromium.fyi

and while removing that nonexistent waterfall bot's description from src/testing/buildbot/waterfalls.pyl it was discovered that the following bot isn't running any tests:

https://ci.chromium.org/buildbot/chromium.clang/UBSanVptr%20Linux/

Not sure whether this bot was supposed to be a compile-only bot, or whether it was supposed to run the test suite "chromium_linux_clang_and_gl_gtests" which the now-nonexistent bot "chromium.fyi:UBSanVptr Linux" used to run. If anyone wants to make this bot run tests, you can add back in the specification of this bot to the correct section of waterfalls.pyl.

If it's supposed to be compile-only, feel free to close this as WontFix.

 

Comment 1 by h...@chromium.org, Feb 21 2018

We have https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxUBSanVptr/ which builds and runs tests using tip-of-tree clang.


I guess we want to keep "UBSanVptr Linux" too. I'm not sure chromium.clang is the best place for it though. It was probably on chromium.fyi before since it was a somewhat experimental config. It doesn't look like we have that config running anywhere else.

Maybe we should just give "UBSanVptr Linux" the same test list as ToTLinuxUBSanVptr. My question is who is supposed to keep an eye on it..

Comment 2 by thakis@chromium.org, Feb 21 2018

krasin used to look at that bot. Is there a new krasin? Not really, right?

Comment 3 by kbr@chromium.org, Feb 21 2018

Blockedon: 765859
Note, it looks like the "UBSanVptr Linux" bot was moved from chromium.fyi to chromium.clang in https://chromium-review.googlesource.com/702016 .

We can easily restore the tests that used to run on it by undoing a portion of https://chromium-review.googlesource.com/927882 . Would you like me to do that?

Comment 4 by kcc@google.com, Feb 21 2018

> krasin used to look at that bot. Is there a new krasin? Not really, right?

No really :(

Comment 5 by h...@chromium.org, Feb 22 2018

kbr: Yes please, let's reinstate the tests.

The question of who is supposed to monitor that bot is a different question. In practice, the clang sheriffs are looking at the ToT version anyway.

Comment 6 by kbr@chromium.org, Feb 23 2018

Owner: kbr@chromium.org
Status: Started (was: Untriaged)
No problem, I'll put the tests back on this bot. https://chromium-review.googlesource.com/933862 up for review.

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/782250485426f2b3f9476cffc70f9c9e82a4b806

commit 782250485426f2b3f9476cffc70f9c9e82a4b806
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Feb 23 09:43:13 2018

Reinstate tests on "chromium.clang:UBSanVptr Linux".

Put most of the changes back from
https://chromium-review.googlesource.com/927882 , but moved the bot
from chromium.fyi to chromium.clang.

Reinstated the old exceptions, but left the bot Swarmed, as there
seemed to be no good reason why it wasn't previously Swarmed.

Bug:  814099 
Change-Id: If65efc7656e5622a4cc51232e3b73745e32c6e21
Reviewed-on: https://chromium-review.googlesource.com/933862
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538739}
[modify] https://crrev.com/782250485426f2b3f9476cffc70f9c9e82a4b806/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/782250485426f2b3f9476cffc70f9c9e82a4b806/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/782250485426f2b3f9476cffc70f9c9e82a4b806/testing/buildbot/waterfalls.pyl

Comment 8 by kbr@chromium.org, Feb 23 2018

Blocking: 815183

Comment 9 by kbr@chromium.org, Feb 23 2018

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a2b171c417d416f3868c77272caec9d59414e65

commit 3a2b171c417d416f3868c77272caec9d59414e65
Author: Nico Weber <thakis@chromium.org>
Date: Fri Feb 23 23:47:38 2018

Tweak which tests run on ToTLinuxUBSanVptr and UBSanVptr Linux.

https://chromium-review.googlesource.com/c/chromium/src/+/933862 added
chromium_linux_clang_and_gl_gtests to the UBSanVptr Linux bot, while
the ToT bot only runs chromium_linux_clang_gtests -- and gl_unittests
doesn't run under ubsan yet (see blockers of crbug.com/815183). So
switch UBSanVptr Linux to chromium_linux_clang_gtests instead.

Many of the tests that were run on UBSanVptr Linux do pass, so run
those on ToTLinuxUBSanVptr too. Namely, aura_unittests, capture_unittests,
chromedriver_unittests, components_browsertests, compositor_unittests,
dbus_unittests, events_unittests, gin_unittests, media_unittests,
mojo_common_unittests, mojo_unittests, nacl_loader_unittests,
ui_touch_selection_unittests, and wm_unittests now run on the ToT bot.

Generally check that if a test is disabled on ToTLinuxUBSanVptr
it's disabled for UBSanVptr Linux too (notably, interactive_ui_tests
no longer runs on the non-tot bot, which also doesn't pass. But
services_unittests now does run, like on the tot bot).

Bug:  814099 , 815183
Change-Id: Icef0bd597f740774351a112df1d2c891ee371d24
Reviewed-on: https://chromium-review.googlesource.com/934424
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538947}
[modify] https://crrev.com/3a2b171c417d416f3868c77272caec9d59414e65/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/3a2b171c417d416f3868c77272caec9d59414e65/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/3a2b171c417d416f3868c77272caec9d59414e65/testing/buildbot/waterfalls.pyl

Sign in to add a comment