New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814098 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

EC: TCPM does not retry DR_SWAP after receiving a WAIT

Project Member Reported by dnojiri@chromium.org, Feb 21 2018

Issue description

Currently, after pd_check_dr_role is called, regardless of the DR_SWAP result, the PD_FLAGS_CHECK_DR_ROLE is cleared.

Attached is the EC log where a type-c monitor returned a WAIT as a response to a DR_SWAP request.

If the other side answers our DR_SWAP request with a WAIT message, we want to retry later rather than giving up.

 
ec.no_display_on_cold_reboot.txt
10.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/00ac58809990a041b0ffff442398008b4c4e0adf

commit 00ac58809990a041b0ffff442398008b4c4e0adf
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Wed Feb 21 12:27:09 2018

pd: retry DR_SWAP after a WAIT

If the other side answers our DR_SWAP request with a WAIT message (as
bizarre as it might be), we want to retry later rather than giving up.
Set again the PD_FLAGS_CHECK_DR_ROLE flag in order to do so.

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

BRANCH=fizz
BUG= chromium:814098 
TEST=do repeated cold reset on Fizz connected to the 'interesting' USB-C
screen and see the DP alternate mode negotiated.

Change-Id: Icfb9fa209ce8cbe3c42c1e6946b43464544bdaea
Reviewed-on: https://chromium-review.googlesource.com/921141
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/00ac58809990a041b0ffff442398008b4c4e0adf/common/usb_pd_protocol.c

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018

Labels: merge-merged-firmware-fizz-10139.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/b36899058e52830a48bdaabfbadfe777dc03672f

commit b36899058e52830a48bdaabfbadfe777dc03672f
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Thu Feb 22 20:02:56 2018

pd: retry DR_SWAP after a WAIT

If the other side answers our DR_SWAP request with a WAIT message (as
bizarre as it might be), we want to retry later rather than giving up.
Set again the PD_FLAGS_CHECK_DR_ROLE flag in order to do so.

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

BRANCH=fizz
BUG= chromium:814098 
TEST=do repeated cold reset on Fizz connected to the 'interesting' USB-C
screen and see the DP alternate mode negotiated.

Change-Id: Icfb9fa209ce8cbe3c42c1e6946b43464544bdaea
Reviewed-on: https://chromium-review.googlesource.com/921141
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
(cherry picked from commit 00ac58809990a041b0ffff442398008b4c4e0adf)
Reviewed-on: https://chromium-review.googlesource.com/932522
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>

[modify] https://crrev.com/b36899058e52830a48bdaabfbadfe777dc03672f/common/usb_pd_protocol.c

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2018

Labels: merge-merged-firmware-servo-9040.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/0a8a0859094829536788a8303808dbee14e2f161

commit 0a8a0859094829536788a8303808dbee14e2f161
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Sat Mar 31 00:42:51 2018

pd: retry DR_SWAP after a WAIT

If the other side answers our DR_SWAP request with a WAIT message (as
bizarre as it might be), we want to retry later rather than giving up.
Set again the PD_FLAGS_CHECK_DR_ROLE flag in order to do so.

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

BRANCH=fizz
BUG= chromium:814098 
TEST=do repeated cold reset on Fizz connected to the 'interesting' USB-C
screen and see the DP alternate mode negotiated.

Change-Id: Icfb9fa209ce8cbe3c42c1e6946b43464544bdaea
Reviewed-on: https://chromium-review.googlesource.com/921141
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
(cherry picked from commit 00ac58809990a041b0ffff442398008b4c4e0adf)
Reviewed-on: https://chromium-review.googlesource.com/989074
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Commit-Queue: Nick Sanders <nsanders@chromium.org>
Tested-by: Nick Sanders <nsanders@chromium.org>

[modify] https://crrev.com/0a8a0859094829536788a8303808dbee14e2f161/common/usb_pd_protocol.c

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 8 2018

Labels: merge-merged-firmware-eve-9584.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/79123454f7ec6c831b68dd6cc0f0e0d6dae07fbc

commit 79123454f7ec6c831b68dd6cc0f0e0d6dae07fbc
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Sun Apr 08 19:59:34 2018

pd: retry DR_SWAP after a WAIT

If the other side answers our DR_SWAP request with a WAIT message (as
bizarre as it might be), we want to retry later rather than giving up.
Set again the PD_FLAGS_CHECK_DR_ROLE flag in order to do so.

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

BRANCH=fizz
BUG= chromium:814098 
TEST=do repeated cold reset on Fizz connected to the 'interesting' USB-C
screen and see the DP alternate mode negotiated.

Change-Id: I9fcfbd739a46c06d41ab7fd3fb1fb4b7084f3aa6
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Original-Commit-Id: 00ac58809990a041b0ffff442398008b4c4e0adf
Original-Change-Id: Icfb9fa209ce8cbe3c42c1e6946b43464544bdaea
Original-Reviewed-on: https://chromium-review.googlesource.com/921141
Original-Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Original-Tested-by: Vincent Palatin <vpalatin@chromium.org>
Original-Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Original-Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Original-Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1002112

[modify] https://crrev.com/79123454f7ec6c831b68dd6cc0f0e0d6dae07fbc/common/usb_pd_protocol.c

Sign in to add a comment