New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814059 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 780078



Sign in to add a comment

Rename U2f transport related objects to Fido

Project Member Reported by hongjunchoi@chromium.org, Feb 21 2018

Issue description

Rename U2f{Hid, Ble}Device/Discovery objects to Fido{Hid, Ble} Device/Discovery. For BLE and HID transport, CTAP specification is strict super set of U2F specification. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2

commit aaa7d01349d4621ea2121bcc486a02a3e42ed0a2
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Fri Mar 16 20:11:40 2018

Change U2f prefix to Fido

Rename U2fDevice, U2fHidDevice, U2fBleDevice to FidoDevice,
FidoHidDevice, FidoBleDevice and change prefix of U2fHidMessageCallback
to HidMessageCallback.

Bug:  814059 
Change-Id: Ia77ade2f571325d177872178eaa2f2995bcf3809
Reviewed-on: https://chromium-review.googlesource.com/927809
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543799}
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/BUILD.gn
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/BUILD.gn
[add] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fake_fido_discovery.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fake_fido_discovery.h
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fake_fido_discovery_unittest.cc
[delete] https://crrev.com/61b5f8c81154fbf2c7cc9b67aa6cc84433aea2fd/device/fido/fake_u2f_discovery.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_device.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_device.h
[add] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_discovery.cc
[add] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_discovery.h
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_discovery_unittest.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_hid_device.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_hid_device.h
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_hid_device_unittest.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_hid_discovery.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_hid_discovery.h
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/fido_hid_discovery_unittest.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/mock_fido_device.cc
[rename] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/mock_fido_device.h
[add] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/mock_fido_discovery_observer.cc
[add] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/mock_fido_discovery_observer.h
[delete] https://crrev.com/61b5f8c81154fbf2c7cc9b67aa6cc84433aea2fd/device/fido/mock_u2f_discovery_observer.cc
[delete] https://crrev.com/61b5f8c81154fbf2c7cc9b67aa6cc84433aea2fd/device/fido/mock_u2f_discovery_observer.h
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_ble_device.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_ble_device.h
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_ble_device_unittest.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_ble_discovery.h
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_ble_discovery_unittest.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_ble_transaction.cc
[delete] https://crrev.com/61b5f8c81154fbf2c7cc9b67aa6cc84433aea2fd/device/fido/u2f_discovery.cc
[delete] https://crrev.com/61b5f8c81154fbf2c7cc9b67aa6cc84433aea2fd/device/fido/u2f_discovery.h
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_register_unittest.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_request.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_request.h
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_request_unittest.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/u2f_sign_unittest.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/virtual_u2f_device.cc
[modify] https://crrev.com/aaa7d01349d4621ea2121bcc486a02a3e42ed0a2/device/fido/virtual_u2f_device.h

Status: Fixed (was: Assigned)

Sign in to add a comment