New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814053 link

Starred by 4 users
Status: Fixed
Owner:
mvstan...@chromium.org
Closed: Mar 2018
Cc:
bmeu...@chromium.org
mvstan...@chromium.org
sadrul@chromium.org
█ briander...@chromium.org
jarin@chromium.org
█ alexclarke@chromium.org
rmcilroy@chromium.org
nedngu...@google.com
mstarzinger@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7%-2% regression in jetstream at 536349:536534

Project Member Reported by briander...@chromium.org, Feb 21 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 21 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=814053

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=7e85969574072939c88523dd7b7173842e6417dfe2f4353c33a54c1d51929f63


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-pro
chromium-rel-win10
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-nvidia
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 21 2018

Cc: bmeu...@chromium.org nedngu...@google.com mvstan...@chromium.org sadrul@chromium.org
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16b98af7840000

[turbofan] Masking/poisoning in codegen (optimized code, x64) by mvstanton@chromium.org
https://chromium.googlesource.com/v8/v8/+/8f489e73b23f764801a35abaaf10772406fd4209

telemetry: Remove unused LoadTimesTimelineMetric metric. by sadrul@chromium.org
https://chromium.googlesource.com/chromium/src/+/dcbee62f9f44f438edadef4bc08a8351518ee83b

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by sadrul@chromium.org, Feb 22 2018

Owner: mvstan...@chromium.org
https://chromium.googlesource.com/chromium/src/+/dcbee62f9f44f438edadef4bc08a8351518ee83b removes dead code. Assigning to author of the other CL.

Comment 5 by mvstan...@chromium.org, Mar 23 2018

Cc: alexclarke@chromium.org
 Issue 814170  has been merged into this issue.

Comment 6 by mvstan...@chromium.org, Mar 23 2018

Cc: mstarzinger@chromium.org jarin@chromium.org rmcilroy@chromium.org
 Issue 814168  has been merged into this issue.

Comment 7 by mvstan...@chromium.org, Mar 23 2018

Status: Fixed (was: Assigned)
This is fixed by the following commit:

[turbofan] Only lower to PoisonedLoads when --branch-load-poisoning is on.
https://chromium.googlesource.com/v8/v8/+/a4353d1464f5c546774f1ae08d8eebfa31fde963

The problem was we were using the infrastructure from my CL even when branch poisoning wasn't turned on.

Comment 8 by mvstan...@chromium.org, Mar 23 2018 

 Issue 814054  has been merged into this issue.
►

Sign in to add a comment