New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814044 link

Starred by 2 users
Status: Assigned
Owner:
khushals...@chromium.org
Cc:
█ briander...@chromium.org
ericrk@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

74.9%-93.1% regression in blink_perf.canvas at 537243:537521

Project Member Reported by briander...@chromium.org, Feb 21 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 21 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=814044

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2613793238fe1dedcc7bc8421f327b8042685cef9a2c445bee34c699f9dc2a16


Bot(s) for this bug's original alert(s):

android-nexus6
android-nexus7v2
android-webview-nexus6
win-high-dpi
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 6 2018

Cc: ericrk@chromium.org junov@chromium.org khushals...@chromium.org
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11e2229c440000

canvas: Avoid unnecessary book-keeping of images in CanvasImageProvider. by khushalsagar@chromium.org
https://chromium.googlesource.com/chromium/src/+/cde9d1d1e464957716e4e15f44810fe28753e4df

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 5 by khushals...@chromium.org, Mar 6 2018

Components: Internals>GPU>Canvas2D
Looks like things improved when we were keeping these images ref-ed throughout the frame, even though they didn't have anything locked inside cc. So nothing regressed really, things came back to where they were before https://chromium.googlesource.com/chromium/src/+/aa36bffbca291c237487d2374d416a9c59f4de2e.

I'll keep this open to get around to investigate before closing this.

Comment 6 by junov@chromium.org, Jul 25

Cc: -junov@chromium.org
►

Sign in to add a comment