New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814040 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

"WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 21 2018

Issue description

"WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJXZWJWaWV3VGVzdHMvV2ViVmlld1NpemVUZXN0LlNoaW1fVGVzdFJlc2l6ZVdlYnZpZXdXaXRoRGlzcGxheU5vbmVSZXNpemVzQ29udGVudC8wDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by chongz@chromium.org, Feb 21 2018

Cc: fsam...@chromium.org chongz@chromium.org
Owner: m...@chromium.org
Status: Assigned (was: Untriaged)
The test hasn't been touched for over a year. (CCing the original owner fsamuel@)

However the DCHECK was modified recently in 483530c1094f0ad6fe36663262b484be300f472e.
e.g. [31724:31724:0220/153202.804002:FATAL:compositor_frame_sink_support.cc(183)] Check failed: result == ACCEPTED (2 vs. 0)

miu@ Can you help triaging the issue? Thanks!

(Given the low flakiness frequency I will let the test stay for now.)

```
[ RUN      ] WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0
[31724:31724:0220/153201.999205:WARNING:user_policy_manager_factory_chromeos.cc(184)] No policy loaded for known non-enterprise user
[31724:31724:0220/153202.007192:WARNING:user_session_manager.cc(1079)] Attempting to save user password for non enterprise user.
[31724:31724:0220/153202.104572:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[31724:31724:0220/153202.104822:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[31724:31724:0220/153202.105182:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[31724:31724:0220/153202.105957:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[31724:31724:0220/153202.173758:ERROR:wallpaper_controller.cc(1243)] User is ephemeral or guest! Fallback to default wallpaper.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterMediaRoutesObserver(0x1de90025f000)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - taking default action specified at:
../../chrome/browser/apps/app_browsertest_util.cc:68:
    Function call: RegisterMediaSinksObserver(0x1de90025f028)
          Returns: true
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[31724:31724:0220/153202.691057:INFO:CONSOLE(25)] "Script has been successfully injected.", source: file:///b/s/w/ir/chrome/test/data/extensions/platform_apps/web_view/shim/inject_comm_channel.js (25)
[31724:31724:0220/153202.692213:INFO:CONSOLE(2396)] "The resize test has been injected into webview.", source: chrome-extension://bjeodlgnchgjbiglapdooknacnngcflb/main.js (2396)
[31724:31724:0220/153202.694388:INFO:CONSOLE(2406)] "The guest script for a two-way comm channel has been injected into webview.", source: chrome-extension://bjeodlgnchgjbiglapdooknacnngcflb/main.js (2406)
[31724:31724:0220/153202.700520:INFO:CONSOLE(8)] "Reporting connection to embedder.", source: file:///b/s/w/ir/chrome/test/data/extensions/platform_apps/web_view/shim/inject_comm_channel.js (8)
[31724:31724:0220/153202.702717:INFO:CONSOLE(2417)] "A communication channel has been established with webview.", source: chrome-extension://bjeodlgnchgjbiglapdooknacnngcflb/main.js (2417)
[31724:31724:0220/153202.703058:INFO:CONSOLE(2418)] "Resizing <webview> width from 300px to 400px.", source: chrome-extension://bjeodlgnchgjbiglapdooknacnngcflb/main.js (2418)
[31724:31724:0220/153202.747814:ERROR:render_widget_host_impl.cc(2736)] Surface invariants violation: [OOPIF? 1] RenderWidgetSurfaceProperties(size(this: 400x300, other: 300x300))

[31724:31724:0220/153202.804002:FATAL:compositor_frame_sink_support.cc(183)] Check failed: result == ACCEPTED (2 vs. 0)
#0 0x0000041bde0c base::debug::StackTrace::StackTrace()
#1 0x0000041d8c3b logging::LogMessage::~LogMessage()
#2 0x0000060e43f7 viz::CompositorFrameSinkSupport::SubmitCompositorFrame()
#3 0x000002d70f80 content::RenderWidgetHostViewChildFrame::ProcessCompositorFrame()
#4 0x000002b8cacf content::RenderWidgetHostViewGuest::SubmitCompositorFrame()
#5 0x000002d60276 content::RenderWidgetHostImpl::SubmitCompositorFrame()
#6 0x0000026965ea viz::mojom::CompositorFrameSinkStubDispatch::Accept()
#7 0x0000052756f6 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#8 0x0000052752e6 mojo::FilterChain::Accept()
#9 0x000005276a45 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#10 0x00000527c66d mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#11 0x00000527bbac mojo::internal::MultiplexRouter::Accept()
#12 0x0000052752e6 mojo::FilterChain::Accept()
#13 0x0000052734b3 mojo::Connector::ReadSingleMessage()
#14 0x000005273dd1 mojo::Connector::ReadAllAvailableMessages()
#15 0x000005273c79 mojo::Connector::OnHandleReadyInternal()
#16 0x0000027e0c77 mojo::SimpleWatcher::DiscardReadyState()
#17 0x00000526e116 mojo::SimpleWatcher::OnHandleReady()
#18 0x00000526e631 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#19 0x0000041be5c5 base::debug::TaskAnnotator::RunTask()
#20 0x000004277519 base::internal::IncomingTaskQueue::RunTask()
#21 0x0000041e058b base::MessageLoop::RunTask()
#22 0x0000041e091a base::MessageLoop::DeferOrRunPendingTask()
#23 0x0000041e0b7c base::MessageLoop::DoWork()
#24 0x0000041e2c09 base::MessagePumpLibevent::Run()
#25 0x0000041dfea9 base::MessageLoop::Run()
#26 0x00000420b0b9 base::RunLoop::Run()
#27 0x000004832a83 content::RunMessageLoop()
#28 0x0000042acf9c InProcessBrowserTest::QuitBrowsers()
#29 0x0000042ace26 InProcessBrowserTest::PostRunTestOnMainThread()
#30 0x0000047fade6 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#31 0x0000042f29fe ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#32 0x0000042f179a ChromeBrowserMainParts::PreMainMessageLoopRun()
#33 0x0000019c4da3 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#34 0x000002a0c6e1 content::BrowserMainLoop::PreMainMessageLoopRun()
#35 0x000002e45945 content::StartupTaskRunner::RunAllTasksNow()
#36 0x000002a0ae6d content::BrowserMainLoop::CreateStartupTasks()
#37 0x000002a0f333 content::BrowserMainRunnerImpl::Initialize()
#38 0x000002a08862 content::BrowserMain()
#39 0x000004187841 content::ContentMainRunnerImpl::Run()
#40 0x000006227bf7 service_manager::Main()
#41 0x000004185e34 content::ContentMain()
#42 0x0000047fa88b content::BrowserTestBase::SetUp()
#43 0x0000042aba6b InProcessBrowserTest::SetUp()
#44 0x000001d48b31 testing::Test::Run()
#45 0x000001d496f0 testing::TestInfo::Run()
#46 0x000001d49bd7 testing::TestCase::Run()
#47 0x000001d51047 testing::internal::UnitTestImpl::RunAllTests()
#48 0x000001d50c97 testing::UnitTest::Run()
#49 0x0000042c0212 base::TestSuite::Run()
#50 0x0000041b1ba9 ChromeTestSuiteRunner::RunTestSuite()
#51 0x00000482f27c content::LaunchTests()
#52 0x0000041b2074 LaunchChromeTests()
#53 0x0000041b17bd main
#54 0x7f4ce352ff45 __libc_start_main
#55 0x0000005cc8fa _start

Failed to generate minidump.Received signal 6
#0 0x0000041bde0c base::debug::StackTrace::StackTrace()
#1 0x0000041bd901 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f4ce6914330 <unknown>
#3 0x7f4ce3544c37 gsignal
#4 0x7f4ce3548028 abort
#5 0x0000041bc385 base::debug::BreakDebugger()
#6 0x0000041d90d2 logging::LogMessage::~LogMessage()
#7 0x0000060e43f7 viz::CompositorFrameSinkSupport::SubmitCompositorFrame()
#8 0x000002d70f80 content::RenderWidgetHostViewChildFrame::ProcessCompositorFrame()
#9 0x000002b8cacf content::RenderWidgetHostViewGuest::SubmitCompositorFrame()
#10 0x000002d60276 content::RenderWidgetHostImpl::SubmitCompositorFrame()
#11 0x0000026965ea viz::mojom::CompositorFrameSinkStubDispatch::Accept()
#12 0x0000052756f6 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#13 0x0000052752e6 mojo::FilterChain::Accept()
#14 0x000005276a45 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#15 0x00000527c66d mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#16 0x00000527bbac mojo::internal::MultiplexRouter::Accept()
#17 0x0000052752e6 mojo::FilterChain::Accept()
#18 0x0000052734b3 mojo::Connector::ReadSingleMessage()
#19 0x000005273dd1 mojo::Connector::ReadAllAvailableMessages()
#20 0x000005273c79 mojo::Connector::OnHandleReadyInternal()
#21 0x0000027e0c77 mojo::SimpleWatcher::DiscardReadyState()
#22 0x00000526e116 mojo::SimpleWatcher::OnHandleReady()
#23 0x00000526e631 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#24 0x0000041be5c5 base::debug::TaskAnnotator::RunTask()
#25 0x000004277519 base::internal::IncomingTaskQueue::RunTask()
#26 0x0000041e058b base::MessageLoop::RunTask()
#27 0x0000041e091a base::MessageLoop::DeferOrRunPendingTask()
#28 0x0000041e0b7c base::MessageLoop::DoWork()
#29 0x0000041e2c09 base::MessagePumpLibevent::Run()
#30 0x0000041dfea9 base::MessageLoop::Run()
#31 0x00000420b0b9 base::RunLoop::Run()
#32 0x000004832a83 content::RunMessageLoop()
#33 0x0000042acf9c InProcessBrowserTest::QuitBrowsers()
#34 0x0000042ace26 InProcessBrowserTest::PostRunTestOnMainThread()
#35 0x0000047fade6 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#36 0x0000042f29fe ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#37 0x0000042f179a ChromeBrowserMainParts::PreMainMessageLoopRun()
#38 0x0000019c4da3 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#39 0x000002a0c6e1 content::BrowserMainLoop::PreMainMessageLoopRun()
#40 0x000002e45945 content::StartupTaskRunner::RunAllTasksNow()
#41 0x000002a0ae6d content::BrowserMainLoop::CreateStartupTasks()
#42 0x000002a0f333 content::BrowserMainRunnerImpl::Initialize()
#43 0x000002a08862 content::BrowserMain()
#44 0x000004187841 content::ContentMainRunnerImpl::Run()
#45 0x000006227bf7 service_manager::Main()
#46 0x000004185e34 content::ContentMain()
#47 0x0000047fa88b content::BrowserTestBase::SetUp()
#48 0x0000042aba6b InProcessBrowserTest::SetUp()
#49 0x000001d48b31 testing::Test::Run()
#50 0x000001d496f0 testing::TestInfo::Run()
#51 0x000001d49bd7 testing::TestCase::Run()
#52 0x000001d51047 testing::internal::UnitTestImpl::RunAllTests()
#53 0x000001d50c97 testing::UnitTest::Run()
#54 0x0000042c0212 base::TestSuite::Run()
#55 0x0000041b1ba9 ChromeTestSuiteRunner::RunTestSuite()
#56 0x00000482f27c content::LaunchTests()
#57 0x0000041b2074 LaunchChromeTests()
#58 0x0000041b17bd main
#59 0x7f4ce352ff45 __libc_start_main
#60 0x0000005cc8fa _start
  r8: 00001de900049077  r9: 0000000000000d19 r10: 0000000000000008 r11: 0000000000000202
 r12: 00007ffe33e5f708 r13: 00007ffe33e5f6f8 r14: 00007ffe33e5f700 r15: 00001de900049077
  di: 0000000000007bec  si: 0000000000007bec  bp: 00007ffe33e5f0f0  bx: 000000000000002a
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffe33e5efb8
  ip: 00007f4ce3544c37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
[754/998] WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0 (CRASHED)
```

Comment 2 by m...@chromium.org, Feb 22 2018

Cc: m...@chromium.org
Owner: fsam...@chromium.org
Given the test is flaky (passes most of the time), the issue is probably a surface invariants violation as the surface is being created or resized. Only if it failed 100% of the time could it be related to "privileges," IIRC.

Comment 3 by m...@chromium.org, Feb 22 2018

Components: Internals>Services>Viz

Comment 4 by m...@chromium.org, Feb 22 2018

Cc: mgiuca@chromium.org
 Issue 814623  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/956fdba034aa47416fdccb51cb6ab76c9735b411

commit 956fdba034aa47416fdccb51cb6ab76c9735b411
Author: Matt Giuca <mgiuca@chromium.org>
Date: Thu Feb 22 07:57:37 2018

Disable part of WebViewSizeTest on Chrome OS ASan.

Is flakily failing a DCHECK.

Bug:  814040 
Tbr: miu@chromium.org, lfg@chromium.org
Change-Id: If3b5fe09e2fb2ba5feabba2e4c1e5d725500a32c
Reviewed-on: https://chromium-review.googlesource.com/930607
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538381}
[modify] https://crrev.com/956fdba034aa47416fdccb51cb6ab76c9735b411/chrome/browser/apps/guest_view/web_view_browsertest.cc

Labels: -Sheriff-Chromium
Assigned; removing from sheriff queue
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, Feb 22 2018

Labels: Sheriff-Chromium
Detected 34 new flakes for test/step "WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJXZWJWaWV3VGVzdHMvV2ViVmlld1NpemVUZXN0LlNoaW1fVGVzdFJlc2l6ZVdlYnZpZXdXaXRoRGlzcGxheU5vbmVSZXNpemVzQ29udGVudC8wDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Removing one more time; last detected flakes are from before the patch in comment 6 landed.
Sorry, the CL description was wrong. It says "Chrome OS ASan" but it's disabled for all Chrome OS. (I thought it was just ASan until I saw the try flakes.)
Labels: ReleaseBlock-Stable M-66
There is a real surface synchronization bug here. I'm marking as an M66 stable blocker.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 26 2018

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03756e349928b4d45e2bc2bd1715f46d0d8942fc

commit 03756e349928b4d45e2bc2bd1715f46d0d8942fc
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Feb 28 05:21:25 2018

Surface synchronization: Fix BrowserPluginGuest surface invariants violations

This CL fixes a few surface invariants violations in BrowserPluginGuest that
were causing flaky tests.

1. We were using ScreenInfo from BrowserPluginGuest to the child renderer before
   we've grabbed a LocalSurfaceId from the parent. This results in surface
   invariants violations occasionally.

2. There is extension code that races with content code to resize the guest.
   This results in surface invariants violations. The solution is to ignore
   extension code requests and only resize from content. OOPIF-based
   BrowserPluginGuest already does this. Do it for the old code path too.

Bug:  672962 ,  814040 , 791154
TBR: piman@chromium.org (for render_widget_host_view_guest.cc) I used to own that but it moved :(
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib5783dee73ce525004f9e9b06c74a8d703e7157b
Reviewed-on: https://chromium-review.googlesource.com/932964
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539718}
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/components/viz/common/surfaces/parent_local_surface_id_allocator.h
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/renderer/browser_plugin/browser_plugin.h

Status: Fixed (was: Assigned)
I'm fairly confident this is fixed at this point for M66. Marking as FIXED.

Sign in to add a comment