"WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0" is flaky |
|||||||||
Issue description"WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJXZWJWaWV3VGVzdHMvV2ViVmlld1NpemVUZXN0LlNoaW1fVGVzdFJlc2l6ZVdlYnZpZXdXaXRoRGlzcGxheU5vbmVSZXNpemVzQ29udGVudC8wDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 22 2018
Given the test is flaky (passes most of the time), the issue is probably a surface invariants violation as the surface is being created or resized. Only if it failed 100% of the time could it be related to "privileges," IIRC.
,
Feb 22 2018
,
Feb 22 2018
,
Feb 22 2018
Landing a disable here: https://chromium-review.googlesource.com/c/chromium/src/+/930607
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/956fdba034aa47416fdccb51cb6ab76c9735b411 commit 956fdba034aa47416fdccb51cb6ab76c9735b411 Author: Matt Giuca <mgiuca@chromium.org> Date: Thu Feb 22 07:57:37 2018 Disable part of WebViewSizeTest on Chrome OS ASan. Is flakily failing a DCHECK. Bug: 814040 Tbr: miu@chromium.org, lfg@chromium.org Change-Id: If3b5fe09e2fb2ba5feabba2e4c1e5d725500a32c Reviewed-on: https://chromium-review.googlesource.com/930607 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#538381} [modify] https://crrev.com/956fdba034aa47416fdccb51cb6ab76c9735b411/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
Feb 22 2018
Assigned; removing from sheriff queue
,
Feb 22 2018
Detected 34 new flakes for test/step "WebViewTests/WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJXZWJWaWV3VGVzdHMvV2ViVmlld1NpemVUZXN0LlNoaW1fVGVzdFJlc2l6ZVdlYnZpZXdXaXRoRGlzcGxheU5vbmVSZXNpemVzQ29udGVudC8wDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 22 2018
Removing one more time; last detected flakes are from before the patch in comment 6 landed.
,
Feb 23 2018
Sorry, the CL description was wrong. It says "Chrome OS ASan" but it's disabled for all Chrome OS. (I thought it was just ASan until I saw the try flakes.)
,
Feb 25 2018
There is a real surface synchronization bug here. I'm marking as an M66 stable blocker.
,
Feb 26 2018
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 26 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03756e349928b4d45e2bc2bd1715f46d0d8942fc commit 03756e349928b4d45e2bc2bd1715f46d0d8942fc Author: Fady Samuel <fsamuel@chromium.org> Date: Wed Feb 28 05:21:25 2018 Surface synchronization: Fix BrowserPluginGuest surface invariants violations This CL fixes a few surface invariants violations in BrowserPluginGuest that were causing flaky tests. 1. We were using ScreenInfo from BrowserPluginGuest to the child renderer before we've grabbed a LocalSurfaceId from the parent. This results in surface invariants violations occasionally. 2. There is extension code that races with content code to resize the guest. This results in surface invariants violations. The solution is to ignore extension code requests and only resize from content. OOPIF-based BrowserPluginGuest already does this. Do it for the old code path too. Bug: 672962 , 814040 , 791154 TBR: piman@chromium.org (for render_widget_host_view_guest.cc) I used to own that but it moved :( Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib5783dee73ce525004f9e9b06c74a8d703e7157b Reviewed-on: https://chromium-review.googlesource.com/932964 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#539718} [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/components/viz/common/surfaces/parent_local_surface_id_allocator.cc [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/components/viz/common/surfaces/parent_local_surface_id_allocator.h [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/common/browser_plugin/browser_plugin_messages.h [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/03756e349928b4d45e2bc2bd1715f46d0d8942fc/content/renderer/browser_plugin/browser_plugin.h
,
Feb 28 2018
I'm fairly confident this is fixed at this point for M66. Marking as FIXED. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by chongz@chromium.org
, Feb 21 2018Owner: m...@chromium.org
Status: Assigned (was: Untriaged)