mash: RootWindowControllerTest.MoveWindows_Basic fails in shelf code |
|||
Issue descriptionash_unittests --mash --gtest_filter=RootWindowController* [ RUN ] RootWindowControllerTest.MoveWindows_Basic [190913:190913:0220/161942.772261:1322380117471:ERROR:display_manager.cc(1931)] Could not find display:2200000001 [190913:190913:0220/161942.814031:1322380159240:FATAL:shelf_view.cc(366)] Check failed: TYPE_APP_LIST != model_->items()[index].type (2 vs. 2) #0 0x7f4296cf52fc base::debug::StackTrace::StackTrace() #1 0x7f4296d1c07b logging::LogMessage::~LogMessage() #2 0x7f42971bea7b ash::ShelfView::GetIdealBoundsOfItemIcon() #3 0x7f42971c75ef ash::ShelfWidget::GetScreenBoundsOfItemIconForWindow() #4 0x7f42971add12 ash::Shelf::GetScreenBoundsOfItemIconForWindow() #5 0x7f42972ade3a ash::GetMinimizeAnimationTargetBoundsInScreen() #6 0x7f42972adad9 ash::AddLayerAnimationsForMinimize() #7 0x7f42972ae4f9 ash::AnimateHideWindow() #8 0x7f42952c367b wm::VisibilityController::UpdateLayerVisibility() #9 0x7f4295889f37 aura::Window::SetVisible() #10 0x7f4297275058 ash::wm::BaseState::UpdateMinimizedState() #11 0x7f4297277490 ash::wm::DefaultState::EnterToNextState() #12 0x7f429727728d ash::wm::DefaultState::HandleTransitionEvents() #13 0x7f4297274fab ash::wm::BaseState::OnWMEvent() #14 0x7f42972b74b2 ash::wm::WindowState::OnWindowPropertyChanged() #15 0x7f429588c545 aura::Window::AfterPropertyChange() #16 0x7f42957d4d75 ui::PropertyHandler::SetPropertyInternal() #17 0x7f429585ccda ui::PropertyHandler::SetProperty<>() #18 0x00000073ff6b ash::RootWindowControllerTest_MoveWindows_Basic_Test::TestBody() #19 0x000000ab62c6 testing::Test::Run() #20 0x000000ab6d30 testing::TestInfo::Run() #21 0x000000ab7217 testing::TestCase::Run() #22 0x000000abe777 testing::internal::UnitTestImpl::RunAllTests() #23 0x000000abe3c7 testing::UnitTest::Run() #24 0x000000b39352 base::TestSuite::Run() #25 0x000000b3b2e7 base::(anonymous namespace)::LaunchUnitTestsInternal() #26 0x000000b3b16b base::LaunchUnitTests() #27 0x0000008bdf94 main Display config problem? Shelf problem?
,
Feb 26 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd195233eebe960a1062c0a78bd679af2b71f928 commit bd195233eebe960a1062c0a78bd679af2b71f928 Author: Mike Wasserman <msw@chromium.org> Date: Fri Mar 09 00:56:34 2018 mash: Fix ShelfView GetIdealBoundsOfItemIcon helper and enable test Make GetIdealBoundsOfItemIcon handle overflow correctly. Enable RootWindowControllerTest.MoveWindows_Basic in Mash. (mash adds overflow shelf items for the widgets in that test) Bug: 814015 Test: Automated; windows minimize to shelf item or overflow button. Change-Id: I3529f898c8201fe7fa0e2f34ecfe008c2a029272 Reviewed-on: https://chromium-review.googlesource.com/956096 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541971} [modify] https://crrev.com/bd195233eebe960a1062c0a78bd679af2b71f928/ash/shelf/shelf_view.cc [modify] https://crrev.com/bd195233eebe960a1062c0a78bd679af2b71f928/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/bd195233eebe960a1062c0a78bd679af2b71f928/testing/buildbot/filters/mash.ash_unittests.filter
,
Mar 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jamescook@chromium.org
, Feb 21 2018