New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813996 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.2%-47.1% regression in thread_times.key_mobile_sites_smooth at 537298:537429

Project Member Reported by briander...@chromium.org, Feb 21 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 21 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=813996

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b306904dcf81518604a6889ba0b455c121fdde61931719d5684948a3c49dd29a


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus7v2
android-one
android-webview-nexus6
Owner: boliu@chromium.org
Status: Assigned (was: Untriaged)
boliu: The bisect in #2 didn't complete, but it points to your CL, "aw: Make DrawFunctor event toplevel". Looks like most of the graphs recovered, is this already fixed?

Kicked off a second bisect just in case.

Comment 5 by boliu@chromium.org, Mar 6 2018

Owner: ----
Status: Unconfirmed (was: Assigned)
the DrawFunctor CL regressing webview is expected and reported many times already:  crbug.com/813972  essentially webview was missing a toplevel trace event which that CL fixed, so a bunch of cpu time was unaccounted for is now counted as webview cpu usage

that CL is in webview-only code though, so I don't see how it can possibly affect chrome though, so not sure about the non-webview regressions
Cc: chrishtr@chromium.org szager@chromium.org kenrb@chromium.org fsam...@chromium.org kylec...@chromium.org jonr...@chromium.org piman@chromium.org
Owner: szager@chromium.org
Status: Assigned (was: Unconfirmed)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12943902440000

Renderer observer of frame submission by jonross@chromium.org
https://chromium.googlesource.com/chromium/src/+/a2ff4f82109df55045dee9f54985a98054f86dc4

Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org
https://chromium.googlesource.com/chromium/src/+/cf91f7965c29e2bc93e81f79cef5d77481b00e6e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
For my change listed in #6 I have also since landed https://chromium-review.googlesource.com/c/chromium/src/+/934626 which should remove this impact in prod

Sign in to add a comment