New download Manager UI does not have padding on iOS 10 |
|||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): iOS Version: Device: Steps to reproduce: 1.) Load https://www.ubuntu.com/download/desktop/thank-you?version=16.04.3&architecture=amd64 2.) Wait for new download manager UI Observed behavior: Download infobar is not tall enough (see screenshot) Expected behavior: Download UI should have top and bottom padding
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ba6fba31775b7c731be6382281933d2ae17f3bd commit 6ba6fba31775b7c731be6382281933d2ae17f3bd Author: Eugene But <eugenebut@google.com> Date: Tue Feb 27 00:11:45 2018 Fixed New Download Manager view height. Setting layoutMargins on iOS 10 had no effect, so the view did not have any padding (the view hight was the same as statusLabel.heightAnchor). Setting directionalLayoutMargins only added top and bottom margins, not left and right, so using directionalLayoutMargins was not super useful either. This CL simply adds shadow height constant to view.layoutMarginsGuide.topAnchor, which looks cleaner (no OS version conditions and actually work on iOS 10). Bug: 813979 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I574651f8ce459e57667550a67bf68d6e038d74e3 Reviewed-on: https://chromium-review.googlesource.com/927605 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539319} [modify] https://crrev.com/6ba6fba31775b7c731be6382281933d2ae17f3bd/ios/chrome/browser/ui/download/download_manager_view_controller.mm
,
Feb 27 2018
,
Mar 6 2018
Verified on 67.0.3363.0 Canary on iPhone 7plus(iOS 10.3.3) and iPad Air(iOS 10.3.3) Download UI is now having top and bottom padding, Looks good Screenshot: https://drive.google.com/file/d/1n0DKn85k0Y4YFOM8JGcUshTvECLYyB9L/view?usp=sharing |
|||
►
Sign in to add a comment |
|||
Comment 1 by eugene...@chromium.org
, Feb 20 2018