New issue
Advanced search Search tips

Issue 813960 link

Starred by 2 users
Status: Fixed
Owner:
mortonm@chromium.org
Closed: Jun 2018
Cc:
norvez@chromium.org
mnissler@chromium.org
dgarr...@chromium.org
skau@chromium.org
waihong@google.com
xiaochu@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

CQ: platform_AddPrinter failed the command <cmp printing_request.log golden_printing_request_generic.bin>

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 20 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of waihong@google.com

Several CQ failed, like kip, peppy, and tidus.

Builders failed on: 
- kip-paladin: 
  https://luci-milo.appspot.com/buildbot/chromeos/kip-paladin/4402

Comment 1 by waihong@chromium.org, Feb 20 2018

Cc: dgarr...@chromium.org norvez@chromium.org

Comment 2 by norvez@chromium.org, Feb 20 2018

Owner: xiaochu@chromium.org
Status: Assigned (was: Available)

Comment 3 by xiaochu@chromium.org, Feb 20 2018 

I took a look at footmatic-rip filter crashed it seems:

2018-02-20T22:52:30.748395+00:00 NOTICE cupsd[9653]: [Job 1] Started backend /usr/libexec/cups/backend/socket (PID 4)
2018-02-20T22:52:30.748606+00:00 INFO cupsd[9653]: REQUEST localhost - - "POST /printers/FakePrinterID HTTP/1.1" 200 15970 Send-Document successful-ok
2018-02-20T22:52:30.783337+00:00 WARNING kernel: [  965.546883] ------------[ cut here ]------------
2018-02-20T22:52:30.783361+00:00 WARNING kernel: [  965.546903] WARNING: CPU: 0 PID: 9668 at ../../../../../tmp/portage/sys-kernel/chromeos-kernel-4_4-4.4.115-r1371/work/chromeos-kernel-4_4-4.4.115/security/chromiumos/lsm.c:243 chromiumos_security_inode_follow_link+0x63/0x6d
2018-02-20T22:52:30.783365+00:00 WARNING kernel: [  965.546908] Blocked symlink traversal for path fd:1:/var/spool/cups/tmp/5a8ca6aebf251 (see https://goo.gl/8xICW6 for context and rationale)
2018-02-20T22:52:30.783710+00:00 WARNING kernel: [  965.546911] Modules linked in: cmac rfcomm uinput ip6table_filter iwlmvm iwl7000_mac80211 snd_soc_sst_baytrail_pcm snd_soc_sst_ipc iwlwifi snd_hda_codec_hdmi snd_soc_sst_dsp iwl7000_cfg80211 snd_soc_sst_byt_max98090_mach snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core snd_intel_sst_acpi snd_intel_sst_core snd_soc_max98090 snd_soc_sst_mfld_platform snd_soc_sst_acpi snd_soc_sst_match zram fuse option usb_wwan cdc_mbim cdc_wdm cdc_ncm btusb btrtl btbcm btintel bluetooth uvcvideo smsc75xx smsc95xx videobuf2_vmalloc videobuf2_memops usbnet mii videobuf2_v4l2 videobuf2_core joydev
2018-02-20T22:52:30.783717+00:00 WARNING kernel: [  965.547352] CPU: 0 PID: 9668 Comm: foomatic-rip Not tainted 4.4.115-13117-g449852a24bc8 #1
2018-02-20T22:52:30.783720+00:00 WARNING kernel: [  965.547357] Hardware name: Hewlett-Packard kip, BIOS Google_Kip.5216.227.78 06/28/2016
2018-02-20T22:52:30.783723+00:00 WARNING kernel: [  965.547361]  0000000000000286 a599a8d7790acedd ffff8800713d3ba8 ffffffffa22fca56
2018-02-20T22:52:30.783725+00:00 WARNING kernel: [  965.547370]  ffff8800713d3bf8 0000000000000000 ffff8800713d3be8 ffffffffa206b0b2
2018-02-20T22:52:30.783728+00:00 WARNING kernel: [  965.547378]  000000f3713d3c68 ffff88016a2cf360 ffffffffa2c96b40 ffff88016a2cf360
2018-02-20T22:52:30.783730+00:00 WARNING kernel: [  965.547386] Call Trace:
2018-02-20T22:52:30.783732+00:00 WARNING kernel: [  965.547396]  [<ffffffffa22fca56>] dump_stack+0x4d/0x63
2018-02-20T22:52:30.783734+00:00 WARNING kernel: [  965.547403]  [<ffffffffa206b0b2>] __warn+0xca/0xe5
2018-02-20T22:52:30.783737+00:00 WARNING kernel: [  965.547408]  [<ffffffffa206b1b5>] warn_slowpath_fmt+0x5a/0x76
2018-02-20T22:52:30.783739+00:00 WARNING kernel: [  965.547415]  [<ffffffffa21a61cb>] ? dentry_path+0x7d/0xb4
2018-02-20T22:52:30.783742+00:00 WARNING kernel: [  965.547421]  [<ffffffffa22b45b5>] chromiumos_security_inode_follow_link+0x63/0x6d
2018-02-20T22:52:30.783744+00:00 WARNING kernel: [  965.547427]  [<ffffffffa22b8a2e>] security_inode_follow_link+0x3c/0x58
2018-02-20T22:52:30.783746+00:00 WARNING kernel: [  965.547433]  [<ffffffffa219f511>] trailing_symlink+0x11c/0x247
2018-02-20T22:52:30.783748+00:00 WARNING kernel: [  965.547439]  [<ffffffffa2253826>] path_openat+0x18f5/0x2221
2018-02-20T22:52:30.783751+00:00 WARNING kernel: [  965.547445]  [<ffffffffa225825c>] do_filp_open+0x98/0xfe
2018-02-20T22:52:30.783753+00:00 WARNING kernel: [  965.547452]  [<ffffffffa2115cf6>] ? __might_sleep+0x9f/0xa6
2018-02-20T22:52:30.783755+00:00 WARNING kernel: [  965.547459]  [<ffffffffa27c605a>] ? _raw_spin_unlock+0xe/0x20
2018-02-20T22:52:30.783758+00:00 WARNING kernel: [  965.547464]  [<ffffffffa225ec2f>] ? get_unused_fd_flags+0x2ad/0x2d3
2018-02-20T22:52:30.783760+00:00 WARNING kernel: [  965.547469]  [<ffffffffa224cd50>] SyS_open+0x192/0x2b0
2018-02-20T22:52:30.783762+00:00 WARNING kernel: [  965.547474]  [<ffffffffa224cd50>] ? SyS_open+0x192/0x2b0
2018-02-20T22:52:30.783764+00:00 WARNING kernel: [  965.547480]  [<ffffffffa27c644d>] entry_SYSCALL_64_fastpath+0x21/0x95
2018-02-20T22:52:30.783767+00:00 WARNING kernel: [  965.547485] ---[ end trace 82a9ddc6c6b4658a ]---
2018-02-20T22:52:30.784214+00:00 NOTICE cupsd[9653]: [Job 1] PID 3 (/usr/libexec/cups/filter/foomatic-rip) stopped with status 9.
2018-02-20T22:52:30.807176+00:00 INFO crash_reporter[9670]: libminijail[9670]: mount /dev/log -> /dev/log type ''

Comment 4 by xiaochu@chromium.org, Feb 20 2018

Cc: skau@chromium.org

Comment 5 by norvez@chromium.org, Feb 20 2018

Cc: mnissler@chromium.org xiaochu@chromium.org
Owner: mortonm@chromium.org
I suspect it's this CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/472908

In the syslog there's an entry about blocked symlink traversal
"
2018-02-20T22:52:30.783361+00:00 WARNING kernel: [  965.546903] WARNING: CPU: 0 PID: 9668 at ../../../../../tmp/portage/sys-kernel/chromeos-kernel-4_4-4.4.115-r1371/work/chromeos-kernel-4_4-4.4.115/security/chromiumos/lsm.c:243 chromiumos_security_inode_follow_link+0x63/0x6d
2018-02-20T22:52:30.783365+00:00 WARNING kernel: [  965.546908] Blocked symlink traversal for path fd:1:/var/spool/cups/tmp/5a8ca6aebf251 (see https://goo.gl/8xICW6 for context and rationale)
2018-02-20T22:52:30.783710+00:00 WARNING kernel: [  965.546911] Modules linked in: cmac rfcomm uinput ip6table_filter iwlmvm iwl7000_mac80211 snd_soc_sst_baytrail_pcm snd_soc_sst_ipc iwlwifi snd_hda_codec_hdmi snd_soc_sst_dsp iwl7000_cfg80211 snd_soc_sst_byt_max98090_mach snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core snd_intel_sst_acpi snd_intel_sst_core snd_soc_max98090 snd_soc_sst_mfld_platform snd_soc_sst_acpi snd_soc_sst_match zram fuse option usb_wwan cdc_mbim cdc_wdm cdc_ncm btusb btrtl btbcm btintel bluetooth uvcvideo smsc75xx smsc95xx videobuf2_vmalloc videobuf2_memops usbnet mii videobuf2_v4l2 videobuf2_core joydev
2018-02-20T22:52:30.783717+00:00 WARNING kernel: [  965.547352] CPU: 0 PID: 9668 Comm: foomatic-rip Not tainted 4.4.115-13117-g449852a24bc8 #1
2018-02-20T22:52:30.783720+00:00 WARNING kernel: [  965.547357] Hardware name: Hewlett-Packard kip, BIOS Google_Kip.5216.227.78 06/28/2016
2018-02-20T22:52:30.783723+00:00 WARNING kernel: [  965.547361]  0000000000000286 a599a8d7790acedd ffff8800713d3ba8 ffffffffa22fca56
2018-02-20T22:52:30.783725+00:00 WARNING kernel: [  965.547370]  ffff8800713d3bf8 0000000000000000 ffff8800713d3be8 ffffffffa206b0b2
2018-02-20T22:52:30.783728+00:00 WARNING kernel: [  965.547378]  000000f3713d3c68 ffff88016a2cf360 ffffffffa2c96b40 ffff88016a2cf360
2018-02-20T22:52:30.783730+00:00 WARNING kernel: [  965.547386] Call Trace:
2018-02-20T22:52:30.783732+00:00 WARNING kernel: [  965.547396]  [<ffffffffa22fca56>] dump_stack+0x4d/0x63
2018-02-20T22:52:30.783734+00:00 WARNING kernel: [  965.547403]  [<ffffffffa206b0b2>] __warn+0xca/0xe5
2018-02-20T22:52:30.783737+00:00 WARNING kernel: [  965.547408]  [<ffffffffa206b1b5>] warn_slowpath_fmt+0x5a/0x76
2018-02-20T22:52:30.783739+00:00 WARNING kernel: [  965.547415]  [<ffffffffa21a61cb>] ? dentry_path+0x7d/0xb4
2018-02-20T22:52:30.783742+00:00 WARNING kernel: [  965.547421]  [<ffffffffa22b45b5>] chromiumos_security_inode_follow_link+0x63/0x6d
2018-02-20T22:52:30.783744+00:00 WARNING kernel: [  965.547427]  [<ffffffffa22b8a2e>] security_inode_follow_link+0x3c/0x58
2018-02-20T22:52:30.783746+00:00 WARNING kernel: [  965.547433]  [<ffffffffa219f511>] trailing_symlink+0x11c/0x247
2018-02-20T22:52:30.783748+00:00 WARNING kernel: [  965.547439]  [<ffffffffa2253826>] path_openat+0x18f5/0x2221
2018-02-20T22:52:30.783751+00:00 WARNING kernel: [  965.547445]  [<ffffffffa225825c>] do_filp_open+0x98/0xfe
2018-02-20T22:52:30.783753+00:00 WARNING kernel: [  965.547452]  [<ffffffffa2115cf6>] ? __might_sleep+0x9f/0xa6
2018-02-20T22:52:30.783755+00:00 WARNING kernel: [  965.547459]  [<ffffffffa27c605a>] ? _raw_spin_unlock+0xe/0x20
2018-02-20T22:52:30.783758+00:00 WARNING kernel: [  965.547464]  [<ffffffffa225ec2f>] ? get_unused_fd_flags+0x2ad/0x2d3
2018-02-20T22:52:30.783760+00:00 WARNING kernel: [  965.547469]  [<ffffffffa224cd50>] SyS_open+0x192/0x2b0
2018-02-20T22:52:30.783762+00:00 WARNING kernel: [  965.547474]  [<ffffffffa224cd50>] ? SyS_open+0x192/0x2b0
2018-02-20T22:52:30.783764+00:00 WARNING kernel: [  965.547480]  [<ffffffffa27c644d>] entry_SYSCALL_64_fastpath+0x21/0x95
2018-02-20T22:52:30.783767+00:00 WARNING kernel: [  965.547485] ---[ end trace 82a9ddc6c6b4658a ]---
2018-02-20T22:52:30.784214+00:00 NOTICE cupsd[9653]: [Job 1] PID 3 (/usr/libexec/cups/filter/foomatic-rip) stopped with status 9.
"

Comment 6 by dgarr...@chromium.org, Feb 20 2018 

I agree. That same CL was in a build with a similar failure over the last weekend.

Comment 7 by mortonm@chromium.org, Feb 21 2018 

Yeah, looks like something is relying on traversing a symlink in /var/spool, which will be blocked by this CL, probably causing the crash. I did a remote trybot run on one of the bots that failed during the previous CQ run, and it succeeded, but looks like the problem is indeed with this CL -- I'll see if I can reproduce this test crash on my local device.

Comment 8 by skau@chromium.org, Feb 21 2018 

Can't open the file in /var/spool/cups/tmp

2018-02-20T22:45:28.351336+00:00 DEBUG cupsd[5569]: [Job 1] foomatic-rip version 1.17.8 running...
2018-02-20T22:45:28.351349+00:00 DEBUG cupsd[5569]: [Job 1] Process is dying with \"Unable to open PPD file /var/spool/cups/tmp/5a8ca50457144

Comment 9 by skau@chromium.org, Feb 21 2018 

Looks like the sticky bit is set on /var/spool/cups/tmp which prevents it from being traversed.

drwxrwx--T. 2 cups cups 4096 Feb 20 10:11 tmp

‘T’
If the restricted deletion flag or sticky bit is set but the other-executable bit is not set.[1]

[1] https://www.gnu.org/software/coreutils/manual/html_node/What-information-is-listed.html#What-information-is-listed

Comment 10 by mortonm@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)
Fix was added in CL:953164 and landed as https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8c48f932f4789a0b673d13a061d8cc2627003885.
►

Sign in to add a comment