Issue metadata
Sign in to add a comment
|
2.8%-19.6% regression in thread_times.tough_scrolling_cases at 537290:537506 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 20 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14f1bef7840000
,
Mar 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12e072e2440000
,
Mar 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12eca532440000
,
Mar 6 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12e072e2440000
,
Mar 6 2018
📍 Found significant differences after each of 5 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12eca532440000 Renderer observer of frame submission by jonross@chromium.org https://chromium.googlesource.com/chromium/src/+/a2ff4f82109df55045dee9f54985a98054f86dc4 Mac SelectFileDialog TLC by tapted@chromium.org https://chromium.googlesource.com/chromium/src/+/4de65ba04a18745d4963ca386a3e3f2b1735135a Revert "Mac SelectFileDialog TLC" by thomasanderson@chromium.org https://chromium.googlesource.com/chromium/src/+/374de998ab969466b15844bca93580a2332056ef [SPv175] Enable SlimmingPaintV175 by default by wangxianzhu@chromium.org https://chromium.googlesource.com/chromium/src/+/0a9a5c311a1d3a298f952e495510bd6fe3faa2f6 Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org https://chromium.googlesource.com/chromium/src/+/cf91f7965c29e2bc93e81f79cef5d77481b00e6e Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 6 2018
-me (since both my CL and its revert are there..)
,
Mar 6 2018
,
Mar 6 2018
,
Mar 6 2018
There was a regression caused by my CL in #6, but I've since landed https://chromium-review.googlesource.com/c/chromium/src/+/934626 which should remove this impact in prod
,
Mar 6 2018
,
Mar 6 2018
The chart in Pinpoint shows three jumps that are about the same size. +tdresser, the benchmark owner: are all of these jumps significant? Renderer observer of frame submission by jonross@chromium.org [SPv175] Enable SlimmingPaintV175 by default by wangxianzhu@chromium.org Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org
,
Mar 6 2018
I suspect we'll be fine accepting the SPV175 change, but we should make sure they're aware of the regression. Jon has addressed the impact of his change, just leaving Stefan's change, which I think is worth following up on.
,
Mar 6 2018
SPv175 has been disabled in M66 and ToT, so there should be no remaining regressions caused by SPv175.
,
Mar 6 2018
Yep, this is mine; I have a patch in progress.
,
Mar 16 2018
,
Aug 10
Is this regression recovered now? |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 20 2018