New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813956 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 770343



Sign in to add a comment

2.8%-19.6% regression in thread_times.tough_scrolling_cases at 537290:537506

Project Member Reported by briander...@chromium.org, Feb 20 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 20 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=813956

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1c9e64740bd409f93287231a592d5b2f02db8b1df5d08bc9bc1f73854578e082


Bot(s) for this bug's original alert(s):

android-webview-nexus6
chromium-rel-mac11-air
chromium-rel-win7-gpu-intel
chromium-rel-win8-dual
linux-release
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12e072e2440000
Cc: tapted@chromium.org a...@chromium.org szager@chromium.org kenrb@chromium.org kylec...@chromium.org chrishtr@chromium.org piman@chromium.org jonr...@chromium.org wangxianzhu@chromium.org thomasanderson@chromium.org rsesek@chromium.org fsam...@chromium.org
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12eca532440000

Renderer observer of frame submission by jonross@chromium.org
https://chromium.googlesource.com/chromium/src/+/a2ff4f82109df55045dee9f54985a98054f86dc4

Mac SelectFileDialog TLC by tapted@chromium.org
https://chromium.googlesource.com/chromium/src/+/4de65ba04a18745d4963ca386a3e3f2b1735135a

Revert "Mac SelectFileDialog TLC" by thomasanderson@chromium.org
https://chromium.googlesource.com/chromium/src/+/374de998ab969466b15844bca93580a2332056ef

[SPv175] Enable SlimmingPaintV175 by default by wangxianzhu@chromium.org
https://chromium.googlesource.com/chromium/src/+/0a9a5c311a1d3a298f952e495510bd6fe3faa2f6

Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org
https://chromium.googlesource.com/chromium/src/+/cf91f7965c29e2bc93e81f79cef5d77481b00e6e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -tapted@chromium.org
-me (since both my CL and its revert are there..)
Cc: -thomasanderson@chromium.org
Cc: -rsesek@chromium.org
There was a regression caused by my CL in #6, but I've since landed https://chromium-review.googlesource.com/c/chromium/src/+/934626 which should remove this impact in prod
Blocking: 770343

Comment 12 by dtu@chromium.org, Mar 6 2018

Cc: dtu@chromium.org tdres...@chromium.org
The chart in Pinpoint shows three jumps that are about the same size. +tdresser, the benchmark owner: are all of these jumps significant?

Renderer observer of frame submission by jonross@chromium.org

[SPv175] Enable SlimmingPaintV175 by default by wangxianzhu@chromium.org

Omit the parent LayoutView's scroll offset from FrameRect by szager@chromium.org
I suspect we'll be fine accepting the SPV175 change, but we should make sure they're aware of the regression.

Jon has addressed the impact of his change, just leaving Stefan's change, which I think is worth following up on.
SPv175 has been disabled in M66 and ToT, so there should be no remaining regressions caused by SPv175.

Yep, this is mine; I have a patch in progress.
Cc: skobes@chromium.org alexclarke@chromium.org
 Issue 814154  has been merged into this issue.
Is this regression recovered now?

Sign in to add a comment