Issue metadata
Sign in to add a comment
|
Copied website is in the omnibox when subsequent new tabs are opened. |
||||||||||||||||||||||
Issue descriptionApp Version: 66.0.3351.0 canary iOS Version: 10.3.3 , 11.2.5 Device: iPad ONLY UR: nytimes.com Steps to Reproduce: 1.Launch app. Go to any website. 2.Long press in the omnibox , do a “Select All” and a “Copy” 3.Open a new tab and Paste the copied website.(Do not tap on Go) 4.Tap on + and Open a new tab. Observed results: Copied website is in the omnibox in subsequent new tabs. Expected results: Copied website should not be in the omnibox in subsequent new tabs. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build : M64- No Bug reproducible on current beta channel build :M65- No Type-bug-regression? Yes Video: https://drive.google.com/file/d/1kmkEFIKvo-HNsMtiZ_CP2rAXFHBprHSf/view?usp=sharing
,
Feb 21 2018
stk@ could you PTAL.
,
Feb 27 2018
,
Mar 13 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d21e3816b10d22501455fea1468d56df514ea442 commit d21e3816b10d22501455fea1468d56df514ea442 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Tue Mar 13 16:11:30 2018 Defocus the omnibox when switching tabs. CL 905511 introduced a bug where previously BVC was defocusing the omnibox by sending selectedTabChanged to the toolbar, but this was broken. Since the location bar now directly observes the webstate with its mediator, use this to defocus omnibox when the webstate changes. Bug: 813944 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc67faaae115032e0a3c6e6b5e3879d7e52f8f0f Reviewed-on: https://chromium-review.googlesource.com/960663 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542817} [modify] https://crrev.com/d21e3816b10d22501455fea1468d56df514ea442/ios/chrome/browser/ui/location_bar/location_bar_consumer.h [modify] https://crrev.com/d21e3816b10d22501455fea1468d56df514ea442/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/d21e3816b10d22501455fea1468d56df514ea442/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [modify] https://crrev.com/d21e3816b10d22501455fea1468d56df514ea442/ios/chrome/browser/ui/location_bar/location_bar_mediator_unittest.mm
,
Mar 13 2018
This should fix it, please check on latest canary. Once verified, this should be cherry-picked.
,
Mar 13 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 14 2018
Verified in: App Version: 67.0.3370.0 canary iOS Versions: 10.3.3, 11.3 beta 5 Devices: iPads ONLY Issue is fixed. Copied URL is not in the omnibox when subsequent new tabs are opened. Video: https://drive.google.com/open?id=127ssM-c5NrFjlFEFucO0IdtagT2vHLNq
,
Mar 15 2018
Please request merge approval
,
Mar 16 2018
,
Mar 16 2018
This bug requires manual review: Less than 28 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 19 2018
,
Mar 23 2018
Friendly ping
,
Mar 23 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15390e2936840c67c4b4b1706c3a0aaa0131aac4 commit 15390e2936840c67c4b4b1706c3a0aaa0131aac4 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Mar 23 18:13:49 2018 Defocus the omnibox when switching tabs. CL 905511 introduced a bug where previously BVC was defocusing the omnibox by sending selectedTabChanged to the toolbar, but this was broken. Since the location bar now directly observes the webstate with its mediator, use this to defocus omnibox when the webstate changes. Bug: 813944 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc67faaae115032e0a3c6e6b5e3879d7e52f8f0f Reviewed-on: https://chromium-review.googlesource.com/960663 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542817}(cherry picked from commit d21e3816b10d22501455fea1468d56df514ea442) Reviewed-on: https://chromium-review.googlesource.com/978187 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#403} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/15390e2936840c67c4b4b1706c3a0aaa0131aac4/ios/chrome/browser/ui/location_bar/location_bar_consumer.h [modify] https://crrev.com/15390e2936840c67c4b4b1706c3a0aaa0131aac4/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/15390e2936840c67c4b4b1706c3a0aaa0131aac4/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [modify] https://crrev.com/15390e2936840c67c4b4b1706c3a0aaa0131aac4/ios/chrome/browser/ui/location_bar/location_bar_mediator_unittest.mm
,
Mar 28 2018
Verified on chrome beta version 66.0.3359.63 on iPad Pro 11.2.6, iPad Mini with iOS 10.3.3 following steps mentioned comment #0. Copied website is not displayed in new tabs opened. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vbhatso...@chromium.org
, Feb 20 2018