New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 813941 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 803314



Sign in to add a comment

Audit auto-reverts for test failures.

Project Member Reported by robert...@chromium.org, Feb 20 2018

Issue description

The audit app should correctly audit auto-reverts created by Findit for test failures.

The only change in behavior is to validate that the sample step of the sample failed build is indeed failed (instead of always checking the 'compile' step.)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bdd4cd199e6f07aa6e545b46764779ff2544e9fa

commit bdd4cd199e6f07aa6e545b46764779ff2544e9fa
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Feb 21 00:29:11 2018

[cr-audit-commits] Support auditing reverts for test.

This change makes audits to auto-reverts pass if they point to a build
where the sample failed test is failed. (Instead of necessarily the
compile step)

This also doubles the daily limits for auto-reverts and auto-commits.

R=chanli,stgao,lijeffrey,wylieb
BUG= 813941 

Change-Id: I7c0c6a84f7d5dc0392865a498a25aaed6ef5fb3b
Reviewed-on: https://chromium-review.googlesource.com/927684
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/bdd4cd199e6f07aa6e545b46764779ff2544e9fa/go/src/infra/appengine/cr-audit-commits/app/findit_rules_test.go
[modify] https://crrev.com/bdd4cd199e6f07aa6e545b46764779ff2544e9fa/go/src/infra/appengine/cr-audit-commits/app/utils.go
[modify] https://crrev.com/bdd4cd199e6f07aa6e545b46764779ff2544e9fa/go/src/infra/appengine/cr-audit-commits/app/rules_config.go
[modify] https://crrev.com/bdd4cd199e6f07aa6e545b46764779ff2544e9fa/go/src/infra/appengine/cr-audit-commits/app/findit_rules.go

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ea60b1b1a1ebebe1f6804b0209555efc272ec891

commit ea60b1b1a1ebebe1f6804b0209555efc272ec891
Author: Chan <chanli@chromium.org>
Date: Wed Feb 21 01:07:41 2018

[Findit] Add sample failed step in revert reason.

Since now we begin to auto-revert culprits of consistent test failures, add a sample failed step name to the revert reason.

This can help audit app to better audit Findit's auto-reverted commits.

Bug:  813941 
Change-Id: Ib5e3f5087bf77edf7174d29b2f5b6e979f6de8e8
Reviewed-on: https://chromium-review.googlesource.com/927783
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/ea60b1b1a1ebebe1f6804b0209555efc272ec891/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/ea60b1b1a1ebebe1f6804b0209555efc272ec891/appengine/findit/services/gerrit.py
[modify] https://crrev.com/ea60b1b1a1ebebe1f6804b0209555efc272ec891/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/ea60b1b1a1ebebe1f6804b0209555efc272ec891/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/ea60b1b1a1ebebe1f6804b0209555efc272ec891/appengine/findit/pipelines/test/create_revert_cl_pipeline_test.py

Status: Fixed (was: Started)

Sign in to add a comment