Issue metadata
Sign in to add a comment
|
Use video capturer API in devtools even if viz is not enabled |
||||||||||||||||||||
Issue descriptionDevToolsFrameTraceRecorderForViz also works when viz is not enabled, but we don't use it in that case because I'm not confident it performs as well as the legacy code (DevToolsFrameTraceRecorder). I believe the following set of tasks will raise the performance of DevToolsFrameTraceRecorderForViz to the same level as DevToolsFrameTraceRecorder and will allow us to use DevToolsFrameTraceRecorderForViz everywhere instead of DevToolsFrameTraceRecorder. 1) Record submission time of each CompositorFrame and send it back with the snapshot. 2) Add a method to FrameSinkVideoCapturer that disables resize throttling in order to avoid letterboxing. 3) Add support for ARGB readback to avoid conversion client-side. 4) Add an option to FrameSinkVideoCapturer to not capture snapshot if damage comes from the children of the target frame sink not the target itself. 5) Add an option to avoid sending refresh frame when capture starts.
,
Feb 20 2018
,
Mar 5 2018
Same applies to DevToolsEyeDropper
,
Mar 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3 commit ca5e7cb5ad8a49460a6605a7cf27f52807da63c3 Author: Saman Sami <samans@chromium.org> Date: Sat Mar 10 02:34:10 2018 viz: Add method to configure resize throttling in FrameSinkVideoCapturer Currently snapshots in DevTools are letterboxed if the renderer is resized multiple times. Although this might be desirable for other usages of FrameSinkVideoCapturer, we definitely don't want this for DevTools, so add a method to configure resize throttling period. Bug: 813929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I12807e57a0b9a4a2131c46a97c004fb2d577ea2f Reviewed-on: https://chromium-review.googlesource.com/954012 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#542326} [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.h [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/content/browser/devtools/devtools_frame_trace_recorder_for_viz.cc [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/content/browser/media/capture/frame_sink_video_capture_device_unittest.cc [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/media/capture/content/video_capture_oracle.cc [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/media/capture/content/video_capture_oracle.h [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/media/capture/content/video_capture_oracle_unittest.cc [modify] https://crrev.com/ca5e7cb5ad8a49460a6605a7cf27f52807da63c3/services/viz/privileged/interfaces/compositing/frame_sink_video_capture.mojom
,
Mar 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/561d774c9b98c6dea59ff414593ddc4942127c5e commit 561d774c9b98c6dea59ff414593ddc4942127c5e Author: Saman Sami <samans@chromium.org> Date: Sat Mar 17 02:22:32 2018 viz: Add method to disable auto throttling in FrameSinkVideoCapturer As long as DevTools eyedropper tool is concerned, a snapshot is useless if any sort of downscaling has happened on it. Add an option to disable auto-throttling so that we get the highest resolution possible in any circumstances. Also added a missing call to SetMinSizeChangePeriod. Bug: 813929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9cca167e6f015bd12d8ce64c9ba04d87847f1c44 Reviewed-on: https://chromium-review.googlesource.com/963309 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543918} [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.h [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/content/browser/media/capture/frame_sink_video_capture_device_unittest.cc [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/media/capture/content/video_capture_oracle.cc [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/media/capture/content/video_capture_oracle.h [modify] https://crrev.com/561d774c9b98c6dea59ff414593ddc4942127c5e/services/viz/privileged/interfaces/compositing/frame_sink_video_capture.mojom
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81a0e6440318cf046372fb549ee10fb3b471526 commit d81a0e6440318cf046372fb549ee10fb3b471526 Author: Saman Sami <samans@chromium.org> Date: Mon Mar 19 04:51:15 2018 Create base::Feature for using video capture API in DevTools Create a base::Feature for using video capture API in DevTools so we can do finch trial independent of Viz. Bug: 813929 Change-Id: I44da043f473d8be663931306e7e9dd296143b1c4 Reviewed-on: https://chromium-review.googlesource.com/963183 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543972} [modify] https://crrev.com/d81a0e6440318cf046372fb549ee10fb3b471526/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/d81a0e6440318cf046372fb549ee10fb3b471526/chrome/browser/devtools/devtools_eye_dropper.h [modify] https://crrev.com/d81a0e6440318cf046372fb549ee10fb3b471526/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/d81a0e6440318cf046372fb549ee10fb3b471526/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/d81a0e6440318cf046372fb549ee10fb3b471526/content/public/common/content_features.cc [modify] https://crrev.com/d81a0e6440318cf046372fb549ee10fb3b471526/content/public/common/content_features.h
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00d3544e2e7b3215e55549e1b0ff5b5d86098071 commit 00d3544e2e7b3215e55549e1b0ff5b5d86098071 Author: Saman Sami <samans@chromium.org> Date: Tue Mar 20 20:22:39 2018 viz: Implement RGBA readback for FrameSinkVideoCapturer Color accuracy is crucial for DevTools eyedropper tool because its whole purpose is to find the RGB values of a certain pixel on screen. FrameSinkVideoCapturer by default produces its VideoFrames in I420 format which has lower resolution for chroma than luma. Although this goes unnoticed by human eyes when you look at the frame as a whole, once you zoom into individual pixels it's clear that pixels don't have the right color. Implement RGBA readback for FrameSinkVideoCapturer and use it in the eye dropper tool to avoid this issue. Bug: 813929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5d624390c6bfef194e81363a5ff4e3427b80e5a4 Reviewed-on: https://chromium-review.googlesource.com/959553 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544505} [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/chrome/browser/devtools/devtools_eye_dropper.h [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/components/viz/common/yuv_readback_unittest.cc [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.h [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/content/browser/media/capture/aura_window_capture_machine.cc [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/media/base/video_frame.cc [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/media/base/video_frame.h [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/media/base/video_util.cc [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/media/base/video_util.h [modify] https://crrev.com/00d3544e2e7b3215e55549e1b0ff5b5d86098071/media/base/video_util_unittest.cc
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6a8d67eac3b75487eba393f832bbfca5cb61911 commit c6a8d67eac3b75487eba393f832bbfca5cb61911 Author: Saman Sami <samans@chromium.org> Date: Tue Mar 20 21:14:36 2018 Remove extra call to SetMinSizeChangePeriod I made a mistake and there are now two calls to SetMinSizeChangePeriod in DevToolsEyeDropper. TBR=caseq@chromium.org Bug: 813929 Change-Id: I4258e3e5c02568c5599a5425973ef1e251b7fad7 Reviewed-on: https://chromium-review.googlesource.com/971766 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544519} [modify] https://crrev.com/c6a8d67eac3b75487eba393f832bbfca5cb61911/chrome/browser/devtools/devtools_eye_dropper.cc
,
Mar 21 2018
,
Mar 21 2018
The old code should be deleted before we fully launch VizDisplayCompositor, marking this is blocking
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c10a636c2569ba85a58a386b19044f0e9f532473 commit c10a636c2569ba85a58a386b19044f0e9f532473 Author: Saman Sami <samans@chromium.org> Date: Tue Mar 27 03:02:19 2018 DevTools: Clip timeline snapshots by content_rect Even with min size change period of zero black borders are still possible, so make sure we clip the video frame by content rect before presenting it to the user. This CL also fixes an issue in PaintCanvasVideoRenderer where we didn't handle visible rect properly. Bug: 813929 Change-Id: I59db4caaa2e8751e65801ed5d0b230ddece8d03b Reviewed-on: https://chromium-review.googlesource.com/974650 Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545920} [modify] https://crrev.com/c10a636c2569ba85a58a386b19044f0e9f532473/content/browser/devtools/devtools_frame_trace_recorder_for_viz.cc [modify] https://crrev.com/c10a636c2569ba85a58a386b19044f0e9f532473/media/renderers/paint_canvas_video_renderer.cc
,
Apr 3 2018
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5340a3f8fbc5e4f5581032e092c7ea6250e9e876 commit 5340a3f8fbc5e4f5581032e092c7ea6250e9e876 Author: Saman Sami <samans@chromium.org> Date: Wed Apr 04 14:21:42 2018 Disable auto throttling in DevToolsFrameTraceRecorderForViz The snapshots get very tiny if many resizes happen during tracing so turn off auto throttling. Bug: 813929 Change-Id: Iceb5f66a7c951bc5e02b2e29b7cb43cccd80bc10 Reviewed-on: https://chromium-review.googlesource.com/980584 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548046} [modify] https://crrev.com/5340a3f8fbc5e4f5581032e092c7ea6250e9e876/content/browser/devtools/devtools_frame_trace_recorder_for_viz.cc
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/493222fd904a5cc78954f0dd569f18544a116de3 commit 493222fd904a5cc78954f0dd569f18544a116de3 Author: Saman Sami <samans@chromium.org> Date: Thu Apr 05 03:41:17 2018 Fix DevTools eyedropper when device scale factor is not 1 FrameSinkVideoCapturer returns a full-resolution snapshot of the page, but DevToolsEyeDropper expects the snapshot to be scaled to the page's dip size. This is problematic for the current configuration of FrameSinkVideoCapturer if device scale factor is anything other than 1. Make sure FrameSinkVideoCaptuerer also scales the snapshot to the expected size. TBR=caseq@chromium.org Bug: 813929 Change-Id: I324c6dccfd7db69e07d2283f826a613946c0bf07 Reviewed-on: https://chromium-review.googlesource.com/986291 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548312} [modify] https://crrev.com/493222fd904a5cc78954f0dd569f18544a116de3/chrome/browser/devtools/devtools_eye_dropper.cc
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bc8d71ce0747ee6287f397e31060c40b4e73a34 commit 4bc8d71ce0747ee6287f397e31060c40b4e73a34 Author: Saman Sami <samans@chromium.org> Date: Wed Apr 18 14:06:28 2018 viz: Implement direct GPU to shared memory copy for RGBA capture For I420 capture we directly copy from GPU memory into shared memory but for RGBA capture there is an extra copy involved. Implement direct GPU to shared memory copy for RGBA capture. Bug: 822264 , 813929 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id359e655cde9d67f12647a0fde6f3751e3d959a4 Reviewed-on: https://chromium-review.googlesource.com/1005404 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551662} [modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/common/frame_sinks/copy_output_result.cc [modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/common/frame_sinks/copy_output_result.h [modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/service/display/gl_renderer_copier.cc [modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/823846f493cd328447473fdc011a35912c39b6b6 commit 823846f493cd328447473fdc011a35912c39b6b6 Author: Saman Sami <samans@chromium.org> Date: Fri Apr 27 21:00:01 2018 Turn UseVideoCaptureApiForDevtoolsSnapshots on by default There has been a 50/50 finch trial on canary and dev going on for this feature and no issues has been reported. Bug: 813929 Change-Id: I79012e9cfa06dfac57c73479aa80d09a050c0395 Reviewed-on: https://chromium-review.googlesource.com/1032889 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#554507} [modify] https://crrev.com/823846f493cd328447473fdc011a35912c39b6b6/content/public/common/content_features.cc
,
May 1 2018
I would like to merge the CL in Comment 16 into M67. This CL turns on usage of video capture API in DevTools by default. There has been a 50/50 finch trial going on on canary and dev channels for the last 4 weeks and no issues have been reported. The old code path will continue to be exercised for half of dev and canary users and if the new feature runs into any problems we can easily turn it off. This feature is technical and does not involve UX changes.
,
May 1 2018
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977944a06abf41976ccb4b2960b3cf0511aa6428 commit 977944a06abf41976ccb4b2960b3cf0511aa6428 Author: Saman Sami <samans@chromium.org> Date: Wed May 02 17:08:31 2018 Enable use of video capture API for DevTools screencasting by default Currently we only use video capture API for screencasting when VizDisplayCompositor is enabled. Also use video capture API when UseVideoCaptureApiForDevToolsSnapshots is enabled. Bug: 813929 Change-Id: Ia3018eed1eda785a260227f89024d20b13da1a97 Reviewed-on: https://chromium-review.googlesource.com/1035616 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#555439} [modify] https://crrev.com/977944a06abf41976ccb4b2960b3cf0511aa6428/content/browser/devtools/protocol/page_handler.cc
,
May 11 2018
,
May 11 2018
I'll reopen this bug and mark closed when we hit M68 stable and the old code path is removed.
,
May 11 2018
Issue 771336 has been merged into this issue.
,
Jul 30
The NextAction date has arrived: 2018-07-30
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93b0efcef471fa5de61ce8d478b7928d9cc96cdc commit 93b0efcef471fa5de61ce8d478b7928d9cc96cdc Author: Saman Sami <samans@chromium.org> Date: Wed Aug 01 14:45:36 2018 Don't instantiate video_consumer_ in PageHandler on Android WebView Video capture doesn't work on Android WebView, so don't instantiate video_consumer_ in PageHandler Bug: 813929 , 865430 Change-Id: I09ecce34f1f2a50d23fc12e0907a0d27bf3bc9d8 Reviewed-on: https://chromium-review.googlesource.com/1157206 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579798} [modify] https://crrev.com/93b0efcef471fa5de61ce8d478b7928d9cc96cdc/content/browser/devtools/protocol/page_handler.cc
,
Aug 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd7b545a89f8bf643883709bcd05ce1fb5aedd94 commit cd7b545a89f8bf643883709bcd05ce1fb5aedd94 Author: Saman Sami <samans@chromium.org> Date: Sat Aug 04 17:14:27 2018 Fix performance timeline screenshots on Android WebView They just don't work at all right now. Video capture doesn't work on Android WebView. We need to call CopyFromSurface. Bug: 813929 , 865430 Change-Id: I4360d3f53f852eb7e3182ac58540a1500cc6fee3 Reviewed-on: https://chromium-review.googlesource.com/1159199 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#580759} [modify] https://crrev.com/cd7b545a89f8bf643883709bcd05ce1fb5aedd94/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/cd7b545a89f8bf643883709bcd05ce1fb5aedd94/content/browser/devtools/render_frame_devtools_agent_host.cc
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9 commit 5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9 Author: Saman Sami <samans@chromium.org> Date: Wed Aug 08 12:12:25 2018 Remove UseVideoCaptureApiForDevToolsSnapshots feature This feature is on in M68, and M69 also has this switch just in case. Remove it in M70. Bug: 813929 , 771337 Change-Id: Id411c324a136bc7321912e2dac6f2eb5ca0892ca Reviewed-on: https://chromium-review.googlesource.com/1162265 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#581525} [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/chrome/browser/devtools/devtools_eye_dropper.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/chrome/browser/devtools/devtools_eye_dropper.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/devtools_frame_trace_recorder.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/devtools_frame_trace_recorder.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/renderer_host/render_widget_host_delegate.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/public/browser/web_contents_observer.h [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/public/common/content_features.cc [modify] https://crrev.com/5cc093d4dcc3af1444f7e1d72e4a284e4b5dc7e9/content/public/common/content_features.h
,
Aug 8
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18d95c0176dcd4b9c835328c6c175fc854bb282b commit 18d95c0176dcd4b9c835328c6c175fc854bb282b Author: Saman Sami <samans@chromium.org> Date: Wed Aug 08 18:11:11 2018 Fix performance timeline screenshots on Android WebView They just don't work at all right now. Video capture doesn't work on Android WebView. We need to call CopyFromSurface. Bug: 813929 , 865430 Change-Id: I4360d3f53f852eb7e3182ac58540a1500cc6fee3 Reviewed-on: https://chromium-review.googlesource.com/1159199 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580759}(cherry picked from commit cd7b545a89f8bf643883709bcd05ce1fb5aedd94) Reviewed-on: https://chromium-review.googlesource.com/1167763 Reviewed-by: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#503} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/18d95c0176dcd4b9c835328c6c175fc854bb282b/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/18d95c0176dcd4b9c835328c6c175fc854bb282b/content/browser/devtools/render_frame_devtools_agent_host.cc |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by samans@chromium.org
, Feb 20 2018