Create template files for ash/components strings and resources |
||
Issue descriptionCreate template files for ash/components strings and resources. And reserve resource ids. How about reserve 700 resource ids for message and 300 for structures?
,
Feb 23 2018
How about renaming the keyboard_shortcut_viewer_strings.grdp file to just "shortcut_viewer_strings.grdp" to match the subdir name? That's what //components does.
,
Feb 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca commit b68ca8a5810b56d73aa0c47d14c17a819d77b0ca Author: wutao <wutao@chromium.org> Date: Sat Feb 24 18:26:32 2018 cros: Rename KSV strings to shortcut_viewer_strings.grdp Rename the keyboard shortcut viewer strings name to match the subdir name. Bug: 813914 Test: Local run and test have no error. Change-Id: Id40dde9cc63bc53020bbb19613d190b199fab75b Reviewed-on: https://chromium-review.googlesource.com/935373 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#539017} [modify] https://crrev.com/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca/ash/components/OWNERS [modify] https://crrev.com/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca/ash/components/ash_components_strings.grd [rename] https://crrev.com/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca/ash/components/shortcut_viewer_strings.grdp
,
Mar 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 21 2018