New issue
Advanced search Search tips

Issue 813914 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Create template files for ash/components strings and resources

Project Member Reported by wutao@chromium.org, Feb 20 2018

Issue description

Create template files for ash/components strings and resources.
And reserve resource ids.


How about reserve 700 resource ids for message and 300 for structures?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80

commit cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80
Author: wutao <wutao@chromium.org>
Date: Wed Feb 21 22:00:35 2018

cros: Create strings and resources grd for ash/components

This cl adds template files for strings and resources in ash/components.

Bug:  813914 
Test: Tested loading the IDR icon.
Change-Id: Id71d98a949bbda15b54ffc9627f696014ad399e8
Reviewed-on: https://chromium-review.googlesource.com/927453
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538226}
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/ash_components_strings.grd
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/resources/BUILD.gn
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/resources/ash_components_resources.grd
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/resources/default_100_percent/shortcut_viewer/ksv_app_icon.png
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/resources/default_200_percent/shortcut_viewer/ksv_app_icon.png
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/BUILD.gn
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_am.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ar.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_bg.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_bn.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ca.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_cs.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_da.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_de.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_el.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_en-GB.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_es-419.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_es.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_et.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_fa.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_fi.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_fil.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_fr.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_gu.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_hi.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_hr.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_hu.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_id.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_it.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_iw.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ja.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_kn.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ko.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_lt.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_lv.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ml.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_mr.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ms.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_nl.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_no.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_pl.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_pt-BR.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_pt-PT.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ro.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ru.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_sk.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_sl.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_sr.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_sv.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_sw.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_ta.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_te.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_th.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_tr.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_uk.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_vi.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_zh-CN.xtb
[add] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/ash/components/strings/ash_components_strings_zh-TW.xtb
[modify] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/chrome/chrome_paks.gni
[modify] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/tools/check_grd_for_unused_strings.py
[modify] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/tools/gritsettings/resource_ids
[modify] https://crrev.com/cd13722f98f6b8b1f70ca23fe8cd8a32dee11d80/tools/gritsettings/translation_expectations.pyl

How about renaming the keyboard_shortcut_viewer_strings.grdp file to just "shortcut_viewer_strings.grdp" to match the subdir name? That's what //components does.


Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca

commit b68ca8a5810b56d73aa0c47d14c17a819d77b0ca
Author: wutao <wutao@chromium.org>
Date: Sat Feb 24 18:26:32 2018

cros: Rename KSV strings to shortcut_viewer_strings.grdp

Rename the keyboard shortcut viewer strings name to match the
subdir name.

Bug:  813914 
Test: Local run and test have no error.
Change-Id: Id40dde9cc63bc53020bbb19613d190b199fab75b
Reviewed-on: https://chromium-review.googlesource.com/935373
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539017}
[modify] https://crrev.com/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca/ash/components/OWNERS
[modify] https://crrev.com/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca/ash/components/ash_components_strings.grd
[rename] https://crrev.com/b68ca8a5810b56d73aa0c47d14c17a819d77b0ca/ash/components/shortcut_viewer_strings.grdp

Comment 4 by wutao@chromium.org, Mar 6 2018

Status: Fixed (was: Available)

Sign in to add a comment