New issue
Advanced search Search tips

Issue 813911 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Jun 2018
Cc:
xiaoh...@chromium.org
bokan@chromium.org
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Flinging in tablet mode is too hard

Project Member Reported by xiaoh...@chromium.org, Feb 20 2018 
Chrome Version: any current Chrome version
OS: ChromeOS

What steps will reproduce the problem?
(1) Put your ChromeOS device in tablet mode by flip the device screen/keyboard 360 degrees.
(2) Open Chrome browser and browser some long web page
(3) Fling the web page as you read down the page

What is the expected result?
Flinging with you thumb should be easy and fluent, like the Android Chrome.

What happens instead?
Flinging seems to stop immediately after the thumb leaves the screen. It makes it very hard to read in tablet mode, since I have to use my thumb to fling like 5 times to scroll one page.  I can only use my thumb because the chromebook is too heavy to hold using one hand.

Comment 1 by omrilio@chromium.org, Feb 26 2018 

Agreed. This is something I'd like to address immediately after the MVP launch of Tablet Chrome.

Comment 2 by omrilio@chromium.org, May 26 2018

Owner: afakhry@chromium.org
Ahmed has taken ownership of this as part of MLP (go/tablet-chrome-mlp)

Comment 3 by bokan@chromium.org, May 31 2018

Cc: bokan@chromium.org

Comment 4 by weifangsun@chromium.org, Jun 15 2018

Components: UI>Shell>TouchView
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a2c644330db7dd98fbf0faa3ac887bed75102e

commit e6a2c644330db7dd98fbf0faa3ac887bed75102e
Author: Ahmed Fakhry <afakhry@google.com>
Date: Wed Jun 20 02:58:41 2018

Use mobile-like flingging in tablet mode

When a Chromebook is flipped into tablet mode, scrolling
and gesture fling events should follow the same curve
used by android in order to have a smoother and more
fluid experience.

BUG= 813911 ,822455

Change-Id: I39b42bdda08a3c20e1b7fab4d8f7e41c2a69b61a
Reviewed-on: https://chromium-review.googlesource.com/1087641
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568704}
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/content/child/blink_platform_impl.cc
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/content/public/browser/content_browser_client.h
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/ui/events/BUILD.gn
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/ui/events/gestures/blink/web_gesture_curve_impl.cc
[modify] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/ui/events/gestures/blink/web_gesture_curve_impl.h
[rename] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/ui/events/mobile_scroller.cc
[rename] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/ui/events/mobile_scroller.h
[rename] https://crrev.com/e6a2c644330db7dd98fbf0faa3ac887bed75102e/ui/events/mobile_scroller_unittest.cc

Comment 6 by afakhry@chromium.org, Jun 20 2018

Status: Fixed (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c944694360378e1ceab56a254e9f68335214808

commit 6c944694360378e1ceab56a254e9f68335214808
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Jul 18 14:16:46 2018

Use MobileScroller instead of cloning it.

Chromecast wants to scroll exactly like Android and for that
the code cloned the mobile scrolling code, but simpler and
easier and with less code and fewer jumbo compilation errors
is to just use the existing code directly.

Only a minor code difference existed and that is controlled with
a conditional statement instead now.

Bug:  813911 
Change-Id: I9d037da9b58c1ad0916dc22ee194328c113075cd
Reviewed-on: https://chromium-review.googlesource.com/1136541
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#576035}
[modify] https://crrev.com/6c944694360378e1ceab56a254e9f68335214808/ui/events/BUILD.gn
[delete] https://crrev.com/ec63e94d1b4ffb3d08c97f5f8c7126ea5dd6d6cf/ui/events/chromecast/scroller.cc
[delete] https://crrev.com/ec63e94d1b4ffb3d08c97f5f8c7126ea5dd6d6cf/ui/events/chromecast/scroller.h
[modify] https://crrev.com/6c944694360378e1ceab56a254e9f68335214808/ui/events/chromecast/scroller_unittest.cc
[modify] https://crrev.com/6c944694360378e1ceab56a254e9f68335214808/ui/events/gestures/blink/BUILD.gn
[modify] https://crrev.com/6c944694360378e1ceab56a254e9f68335214808/ui/events/gestures/blink/web_gesture_curve_impl.cc
[modify] https://crrev.com/6c944694360378e1ceab56a254e9f68335214808/ui/events/mobile_scroller.cc
[modify] https://crrev.com/6c944694360378e1ceab56a254e9f68335214808/ui/events/mobile_scroller.h
►

Sign in to add a comment