New issue
Advanced search Search tips

Issue 813910 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cros splitscreen - Crash when swapping two snapped windows

Project Member Reported by x...@chromium.org, Feb 20 2018

Issue description

Chrome Version: 66.0.3349.0
OS: Chrome

What steps will reproduce the problem?
(1) Have at least two windows open in tablet mode
(2) Enter overview mode and drag one window to snap to right
(3) Snap another window to left
(4) Double tap on the divider to swap two snapped windows

Expected result:
The two windows swap their positions

Actual result:
Chrome crashes.

 

Comment 1 by x...@chromium.org, Feb 20 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/212e48f05bff9aeb25ed95048b632f245f501390

commit 212e48f05bff9aeb25ed95048b632f245f501390
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Feb 21 01:42:02 2018

Cros splitscreen: Fix Chrome crash when swapping two snapped windows.

We should update the two snapped windows state and bounds at the same
time, not one by one. Otherwise it may trigger the unnecessary state
change and cause chrome crash.

Bug:  813910 
Change-Id: I92cfd4986dd34323af43ec77cacfa4cce19da9ce
Reviewed-on: https://chromium-review.googlesource.com/927358
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537982}
[modify] https://crrev.com/212e48f05bff9aeb25ed95048b632f245f501390/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/212e48f05bff9aeb25ed95048b632f245f501390/ash/wm/splitview/split_view_controller_unittest.cc

Comment 3 by x...@chromium.org, Feb 21 2018

Status: Fixed (was: Started)

Sign in to add a comment